rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink().
Subsystems (2)
PATCH 1/1 rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink().
The cited commit accidentally replaced tgt_net with net in rtnl_dellink().
As a result, IFLA_TARGET_NETNSID is ignored if the interface is specified with IFLA_IFNAME or IFLA_ALT_IFNAME.
Let's pass tgt_net to rtnl_dev_get().
--- net/core/rtnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/rtnetlink.c +1 -1
@@ -3288,7 +3288,7 @@ static int rtnl_dellink(struct sk_buff *skb, struct nlmsghdr *nlh,if (ifm->ifi_index >0 ) dev =__dev_get_by_index (tgt_net, ifm->ifi_index);else if (tb[IFLA_IFNAME ] || tb[IFLA_ALT_IFNAME ]) - dev =rtnl_dev_get (net, tb); + dev =rtnl_dev_get (tgt_net, tb);else if (tb[IFLA_GROUP ]) err =rtnl_group_dellink (tgt_net,nla_get_u32 (tb[IFLA_GROUP ]));else
Signature · 1 line
2.30.2
Quoted 9 lines · On Fri, 26 Jul 2024 17:19:53 -0700 Kuniyuki Iwashima wrote:
The cited commit accidentally replaced
tgt_netwith net inrtnl_dellink().As a result,
IFLA_TARGET_NETNSIDis ignored if the interface is specified withIFLA_IFNAMEorIFLA_ALT_IFNAME.Let's pass
tgt_nettortnl_dev_get().Fixes cc6090e985d7 ("net: rtnetlink: introduce helper to get net_device instance by ifname")Signed-off-by Kuniyuki Iwashima <[email protected]>
This patch was applied to netdev/net.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:
Quoted 8 lines · On Fri, 26 Jul 2024 17:19:53 -0700 you wrote:
The cited commit accidentally replaced
tgt_netwith net inrtnl_dellink().As a result,
IFLA_TARGET_NETNSIDis ignored if the interface is specified withIFLA_IFNAMEorIFLA_ALT_IFNAME.Let's pass
tgt_nettortnl_dev_get().[...]
Here is the summary with links:
- [v1,net] rtnetlink: Don't ignore IFLA_TARGET_NETNSID when ifname is specified in rtnl_dellink().
https://git.kernel.org/netdev/net/c/9415d375d852
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html