Skip to contentSkip to conversation

net: mdio: Use of_property_count_u32_elems() to get property length

PATCH Applied Rob Herring (Arm) 2 participants 2 messages Jul 31, 2024 – Aug 2, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: mdio: Use of_property_count_u32_elems() to get property length

Replace of_get_property() with the type specific of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.

---
 drivers/net/mdio/of_mdio.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/net/mdio/of_mdio.c +2 -3
index 08e607f62e10..2f4fc664d2e1 100644
@@ -390,7 +390,7 @@ EXPORT_SYMBOL(of_phy_get_and_connect);
 bool of_phy_is_fixed_link(struct device_node *np)
 {
 	struct device_node *dn;
-	int len, err;
+	int err;
 	const char *managed;
 
 	/* New binding */
@@ -405,8 +405,7 @@ bool of_phy_is_fixed_link(struct device_node *np)
 		return true;
 
 	/* Old binding */
-	if (of_get_property(np, "fixed-link", &len) &&
-	    len == (5 * sizeof(__be32)))
+	if (of_property_count_u32_elems(np, "fixed-link") == 5)
 		return true;
 
 	return false;
Signature · 1 line
2.43.0
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Wed, 31 Jul 2024 14:15:15 -0600 you wrote:

Replace of_get_property() with the type specific of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property() and similar functions. of_get_property() leaks the DT property data pointer which is a problem for dynamically allocated nodes which may be freed.

[...]

Here is the summary with links:
- [net-next] net: mdio: Use of_property_count_u32_elems() to get property length

    https://git.kernel.org/netdev/net-next/c/0b0e9cdb3d1f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html