net: phy: qca807x: Drop unnecessary and broken DT validation
Subsystems (4)
PATCH 1/1 net: phy: qca807x: Drop unnecessary and broken DT validation
The check for "leds" and "gpio-controller" both being present is never true because "leds" is a node, not a property. This could be fixed with a check for child node, but there's really no need for the kernel to validate a DT. Just continue ignoring the LEDs if GPIOs are present.
--- drivers/net/phy/qcom/qca807x.c | 10 ---------- 1 file changed, 10 deletions(-)
drivers/net/phy/qcom/qca807x.c +0 -10
@@ -733,16 +733,6 @@ static int qca807x_probe(struct phy_device *phydev) "qcom,dac-disable-bias-current-tweak");#if IS_ENABLED (CONFIG_GPIOLIB ) -/* Make sure we don't have mixed leds node and gpio-controller -* to prevent registering leds and having gpio-controller usage -* conflicting with them. -*/ -if (of_find_property (node,"leds" ,NULL ) && -of_find_property (node,"gpio-controller" ,NULL )) { -phydev_err (phydev,"Invalid property detected. LEDs and gpio-controller are mutually exclusive." ); -return -EINVAL ; - } -/* Do not register a GPIO controller unless flagged for it */ if (of_property_read_bool (node,"gpio-controller" )) { ret =qca807x_gpio (phydev);
Signature · 1 line
2.43.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 31 Jul 2024 14:17:03 -0600 you wrote:
The check for "leds" and "gpio-controller" both being present is never true because "leds" is a node, not a property. This could be fixed with a check for child node, but there's really no need for the kernel to validate a DT. Just continue ignoring the LEDs if GPIOs are present.
Signed-off-by Rob Herring (Arm) <[email protected]>[...]
Here is the summary with links:
- [net-next] net: phy: qca807x: Drop unnecessary and broken DT validation
https://git.kernel.org/netdev/net-next/c/46e6acfe3501
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html