f2fs: fix to wait dio completion
Subsystems (2)
Chao Yu
maintainerPATCH 1/1 f2fs: fix to wait dio completion
It should wait all existing dio write IOs before block removal, otherwise, previous direct write IO may overwrite data in the block which may be reused by other inode.
Signed-off-by Chao Yu <[email protected]>
--- fs/f2fs/file.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
fs/f2fs/file.c +13 -0
@@ -1056,6 +1056,13 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct dentry *dentry,return err; } +/* +* wait for inflight dio, blocks should be removed after +* IO completion. +*/ +if (attr->ia_size < old_size) +inode_dio_wait (inode); +f2fs_down_write (&fi->i_gc_rwsem[WRITE ]);filemap_invalidate_lock (inode->i_mapping);
@@ -1892,6 +1899,12 @@ static long f2fs_fallocate(struct file *file, int mode,if (ret) goto out; +/* +* wait for inflight dio, blocks should be removed after IO +* completion. +*/ +inode_dio_wait (inode); +if (mode &FALLOC_FL_PUNCH_HOLE ) {if (offset >= inode->i_size) goto out;
Signature · 1 line
2.40.1
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 8 lines · On Thu, 27 Jun 2024 15:17:11 +0800 you wrote:
It should wait all existing dio write IOs before block removal, otherwise, previous direct write IO may overwrite data in the block which may be reused by other inode.
Signed-off-by Chao Yu <[email protected]>[...]
Here is the summary with links:
- [f2fs-dev] f2fs: fix to wait dio completion
https://git.kernel.org/jaegeuk/f2fs/c/e60776860678
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html