f2fs: use f2fs_get_node_page when write inline data
PATCH 1/1 f2fs: use f2fs_get_node_page when write inline data
From: Zijie Wang <[email protected]>
Date: Mon, 1 Apr 2024 21:24:08 +0800
Subject: [PATCH] [f2fs-dev] f2fs: use f2fs_get_node_page when write inline data
We just need inode page when write inline data, use f2fs_get_node_page() to get it instead of using dnode_of_data, which can eliminate unnecessary struct use.
--- fs/f2fs/inline.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-)
fs/f2fs/inline.c +11 -12
@@ -242,33 +242,32 @@ int f2fs_convert_inline_inode(struct inode *inode)int f2fs_write_inline_data (struct inode *inode,struct page *page) { -struct dnode_of_data dn; -int err; +struct f2fs_sb_info *sbi =F2FS_I_SB (inode); +struct page *ipage; -set_new_dnode (&dn, inode,NULL ,NULL ,0 ); - err =f2fs_get_dnode_of_data (&dn,0 ,LOOKUP_NODE ); -if (err) -return err; + ipage =f2fs_get_node_page (sbi, inode->i_ino); +if (IS_ERR (ipage)) +return PTR_ERR (ipage);if (!f2fs_has_inline_data (inode)) { -f2fs_put_dnode (&dn); +f2fs_put_page (ipage,1 );return -EAGAIN ; }f2fs_bug_on (F2FS_I_SB (inode), page->index); -f2fs_wait_on_page_writeback (dn.inode_page,NODE , true, true); -memcpy_from_page (inline_data_addr (inode, dn.inode_page), +f2fs_wait_on_page_writeback (ipage,NODE , true, true); +memcpy_from_page (inline_data_addr (inode, ipage), page,0 ,MAX_INLINE_DATA (inode)); -set_page_dirty (dn.inode_page); +set_page_dirty (ipage);f2fs_clear_page_cache_dirty_tag (page);set_inode_flag (inode,FI_APPEND_WRITE );set_inode_flag (inode,FI_DATA_EXIST ); -clear_page_private_inline (dn.inode_page); -f2fs_put_dnode (&dn); +clear_page_private_inline (ipage); +f2fs_put_page (ipage,1 );return 0 ; }
Signature · 1 line
2.25.1
Quoted 9 lines · wangzijie
From: Zijie Wang <[email protected]>
Date: Mon, 1 Apr 2024 21:24:08 +0800
Subject: [PATCH] [f2fs-dev] f2fs: usef2fs_get_node_pagewhen write inline dataWe just need inode page when write inline data, use
f2fs_get_node_page()to get it instead of usingdnode_of_data, which can eliminate unnecessary struct use.Signed-off-by Zijie Wang <[email protected]>
Thanks,
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 9 lines · On Mon, 1 Apr 2024 13:48:20 +0000 you wrote:
From: Zijie Wang <[email protected]>
Date: Mon, 1 Apr 2024 21:24:08 +0800
Subject: [PATCH] [f2fs-dev] f2fs: usef2fs_get_node_pagewhen write inline dataWe just need inode page when write inline data, use
f2fs_get_node_page()to get it instead of usingdnode_of_data, which can eliminate unnecessary struct use.[...]
Here is the summary with links:
- [f2fs-dev] f2fs: use f2fs_get_node_page when write inline data
https://git.kernel.org/jaegeuk/f2fs/c/aac0828ab000
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html