net: fec: Switch to RUNTIME/SYSTEM_SLEEP_PM_OPS()
Fabio Estevam
reviewerPATCH 1/1 net: fec: Switch to RUNTIME/SYSTEM_SLEEP_PM_OPS()
From: Fabio Estevam <[email protected]>
Replace SET_RUNTIME_PM_OPS()/SET SYSTEM_SLEEP_PM_OPS() with their modern RUNTIME_PM_OPS() and SYSTEM_SLEEP_PM_OPS() alternatives.
The combined usage of pm_ptr() and RUNTIME_PM_OPS/SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code.
This allows removing the __maybe_unused notation from the runtime suspend/resume() functions.
--- drivers/net/ethernet/freescale/fec_main.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/net/ethernet/freescale/fec_main.c +7 -7
@@ -4606,7 +4606,7 @@ fec_drv_remove(struct platform_device *pdev)free_netdev (ndev); } -static int __maybe_unused fec_suspend (struct device *dev) +static int fec_suspend (struct device *dev) {struct net_device *ndev =dev_get_drvdata (dev);struct fec_enet_private *fep =netdev_priv (ndev);
@@ -4659,7 +4659,7 @@ static int __maybe_unused fec_suspend(struct device *dev)return 0 ; } -static int __maybe_unused fec_resume (struct device *dev) +static int fec_resume (struct device *dev) {struct net_device *ndev =dev_get_drvdata (dev);struct fec_enet_private *fep =netdev_priv (ndev);
@@ -4714,7 +4714,7 @@ static int __maybe_unused fec_resume(struct device *dev)return ret; } -static int __maybe_unused fec_runtime_suspend (struct device *dev) +static int fec_runtime_suspend (struct device *dev) {struct net_device *ndev =dev_get_drvdata (dev);struct fec_enet_private *fep =netdev_priv (ndev);
@@ -4725,7 +4725,7 @@ static int __maybe_unused fec_runtime_suspend(struct device *dev)return 0 ; } -static int __maybe_unused fec_runtime_resume (struct device *dev) +static int fec_runtime_resume (struct device *dev) {struct net_device *ndev =dev_get_drvdata (dev);struct fec_enet_private *fep =netdev_priv (ndev);
@@ -4746,14 +4746,14 @@ static int __maybe_unused fec_runtime_resume(struct device *dev) }static const struct dev_pm_ops fec_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(fec_suspend, fec_resume) -SET_RUNTIME_PM_OPS (fec_runtime_suspend, fec_runtime_resume,NULL ) + SYSTEM_SLEEP_PM_OPS(fec_suspend, fec_resume) +RUNTIME_PM_OPS (fec_runtime_suspend, fec_runtime_resume,NULL ) };static struct platform_driver fec_driver = { .driver = { .name =DRIVER_NAME , - .pm = &fec_pm_ops, + .pm =pm_ptr (&fec_pm_ops), .of_match_table = fec_dt_ids, .suppress_bind_attrs = true, },
Signature · 1 line
2.34.1
Quoted 14 lines
Subject: [PATCH net-next] net: fec: Switch to
RUNTIME/SYSTEM_SLEEP_PM_OPS()From: Fabio Estevam <[email protected]>
Replace SET_RUNTIME_PM_OPS()/SET
SYSTEM_SLEEP_PM_OPS()with their modernRUNTIME_PM_OPS()andSYSTEM_SLEEP_PM_OPS()alternatives.The combined usage of
pm_ptr()and RUNTIME_PM_OPS/SYSTEM_SLEEP_PM_OPS()
allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code.
Quoted 4 lines
This allows removing the
__maybe_unusednotation from the runtime suspend/resume() functions.Signed-off-by Fabio Estevam <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 5 Aug 2024 23:16:28 -0300 you wrote:
From: Fabio Estevam <[email protected]>
Replace SET_RUNTIME_PM_OPS()/SET
SYSTEM_SLEEP_PM_OPS()with their modernRUNTIME_PM_OPS()andSYSTEM_SLEEP_PM_OPS()alternatives.The combined usage of
pm_ptr()and RUNTIME_PM_OPS/SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the runtime suspend/resume() functions are used at build time or are simply dead code.[...]
Here is the summary with links:
- [net-next] net: fec: Switch to RUNTIME/SYSTEM_SLEEP_PM_OPS()
https://git.kernel.org/netdev/net-next/c/de6c7b9ada33
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html