net: sunvnet: use ethtool_sprintf/puts
Subsystems (2)
PATCH v2 1/1 net: sunvnet: use ethtool_sprintf/puts
Simpler and allows avoiding manual pointer addition.
Signed-off-by Rosen Penev <[email protected]>
--- drivers/net/ethernet/sun/sunvnet.c | 34 +++++++++--------------------- 1 file changed, 10 insertions(+), 24 deletions(-)
drivers/net/ethernet/sun/sunvnet.c +10 -24
@@ -114,37 +114,23 @@ static void vnet_get_strings(struct net_device *dev, u32 stringset, u8 *buf) {struct vnet *vp = (struct vnet *)netdev_priv (dev);struct vnet_port *port; -char *p = (char *)buf;switch (stringset) {case ETH_SS_STATS :memcpy (buf, ðtool_stats_keys,sizeof (ethtool_stats_keys)); - p +=sizeof (ethtool_stats_keys); + buf +=sizeof (ethtool_stats_keys);rcu_read_lock ();list_for_each_entry_rcu (port, &vp->port_list, list) { -snprintf (p,ETH_GSTRING_LEN ,"p%u.%s-%pM" , - port->q_index, port->switch_port ?"s" :"q" , - port->raddr); - p +=ETH_GSTRING_LEN ; -snprintf (p,ETH_GSTRING_LEN ,"p%u.rx_packets" , - port->q_index); - p +=ETH_GSTRING_LEN ; -snprintf (p,ETH_GSTRING_LEN ,"p%u.tx_packets" , - port->q_index); - p +=ETH_GSTRING_LEN ; -snprintf (p,ETH_GSTRING_LEN ,"p%u.rx_bytes" , - port->q_index); - p +=ETH_GSTRING_LEN ; -snprintf (p,ETH_GSTRING_LEN ,"p%u.tx_bytes" , - port->q_index); - p +=ETH_GSTRING_LEN ; -snprintf (p,ETH_GSTRING_LEN ,"p%u.event_up" , - port->q_index); - p +=ETH_GSTRING_LEN ; -snprintf (p,ETH_GSTRING_LEN ,"p%u.event_reset" , - port->q_index); - p +=ETH_GSTRING_LEN ; +ethtool_sprintf (&buf,"p%u.%s-%pM" , port->q_index, + port->switch_port ?"s" :"q" , + port->raddr); +ethtool_sprintf (&buf,"p%u.rx_packets" , port->q_index); +ethtool_sprintf (&buf,"p%u.tx_packets" , port->q_index); +ethtool_sprintf (&buf,"p%u.rx_bytes" , port->q_index); +ethtool_sprintf (&buf,"p%u.tx_bytes" , port->q_index); +ethtool_sprintf (&buf,"p%u.event_up" , port->q_index); +ethtool_sprintf (&buf,"p%u.event_reset" , port->q_index); }rcu_read_unlock ();break ;
Signature · 1 line
2.46.0
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by David S. Miller <[email protected]>:
Quoted 6 lines · On Fri, 9 Aug 2024 13:55:18 -0700 you wrote:
Simpler and allows avoiding manual pointer addition.
Signed-off-by Rosen Penev <[email protected]>--- drivers/net/ethernet/sun/sunvnet.c | 34 +++++++++--------------------- 1 file changed, 10 insertions(+), 24 deletions(-)
Here is the summary with links:
- [PATCHv2,net-next] net: sunvnet: use ethtool_sprintf/puts
https://git.kernel.org/netdev/net-next/c/f547e956dd84
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html