platform/surface: aggregator_registry: Add Support for various devices
Subsystems (3)
Maximilian Luz
maintainercover platform/surface: aggregator_registry: Add Support for various devices
This series is basically a collection of SAM device enablement patches, for which I only now found the time to clean them up end send them in. It adds Surface SAM support (enabling battery status, keyboard, touchpad, and more) for the following devices:
- Surface Pro 10
- Surface Laptop Go 3
- Surface Laptop Studio 2
- Surface Laptop 6
In addition, this series enables the thermal sensor as well as fan (profile) control and monitoring on the Surface Laptop 5.
Maximilian Luz (5):
platform/surface: aggregator_registry: Add Support for Surface Pro 10 platform/surface: aggregator_registry: Add support for Surface Laptop
Go 3
platform/surface: aggregator_registry: Add support for Surface Laptop
Studio 2
platform/surface: aggregator_registry: Add fan and thermal sensor
support for Surface Laptop 5
platform/surface: aggregator_registry: Add support for Surface Laptop
6
.../surface/surface_aggregator_registry.c | 58 +++++++++++++++++-- 1 file changed, 52 insertions(+), 6 deletions(-)
Signature · 1 line
2.46.0
Maximilian Luz
maintainerPATCH 1/5 platform/surface: aggregator_registry: Add Support for Surface Pro 10
Add SAM client device nodes for the Surface Pro 10. It seems to use the same SAM client devices as the Surface Pro 9, so re-use its node group.
--- drivers/platform/surface/surface_aggregator_registry.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/platform/surface/surface_aggregator_registry.c +4 -1
@@ -324,7 +324,7 @@ static const struct software_node *ssam_node_group_sp8[] = { NULL, }; -/* Devices for Surface Pro 9 */ +/* Devices for Surface Pro 9 and 10 */ static const struct software_node *ssam_node_group_sp9[] = { &ssam_node_root, &ssam_node_hub_kip,
@@ -365,6 +365,9 @@ static const struct acpi_device_id ssam_platform_hub_match[] = {/* Surface Pro 9 */ { "MSHW0343", (unsigned long)ssam_node_group_sp9 }, +/* Surface Pro 10 */ + { "MSHW0510", (unsigned long)ssam_node_group_sp9 }, +/* Surface Book 2 */ { "MSHW0107", (unsigned long)ssam_node_group_gen5 },
Signature · 1 line
2.46.0
Maximilian Luz
maintainerPATCH 2/5 platform/surface: aggregator_registry: Add support for Surface Laptop Go 3
In reply to Maximilian LuzAdd SAM client device nodes for the Surface Laptop Go 3. It seems to use the same SAM client devices as the Surface Laptop Go 1 and 2, so re-use their node group.
--- drivers/platform/surface/surface_aggregator_registry.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/platform/surface/surface_aggregator_registry.c +3 -0
@@ -398,6 +398,9 @@ static const struct acpi_device_id ssam_platform_hub_match[] = {/* Surface Laptop Go 2 */ { "MSHW0290", (unsigned long)ssam_node_group_slg1 }, +/* Surface Laptop Go 3 */ + { "MSHW0440", (unsigned long)ssam_node_group_slg1 }, +/* Surface Laptop Studio */ { "MSHW0123", (unsigned long)ssam_node_group_sls },
Signature · 1 line
2.46.0
Maximilian Luz
maintainerPATCH 3/5 platform/surface: aggregator_registry: Add support for Surface Laptop Studio 2
In reply to Maximilian LuzAdd SAM client device nodes for the Surface Laptop Studio 2 (SLS2). The SLS2 is quite similar to the SLS1, but it does not provide the touchpad as a SAM-HID device. Therefore, add a new node group for the SLS2 and update the comments accordingly. In addition, it uses the new fan control interface.
--- .../surface/surface_aggregator_registry.c | 27 ++++++++++++++++--- 1 file changed, 23 insertions(+), 4 deletions(-)
drivers/platform/surface/surface_aggregator_registry.c +23 -4
@@ -273,8 +273,8 @@ static const struct software_node *ssam_node_group_sl5[] = { NULL, }; -/* Devices for Surface Laptop Studio. */ -static const struct software_node *ssam_node_group_sls[] = { +/* Devices for Surface Laptop Studio 1. */ +static const struct software_node *ssam_node_group_sls1[] = { &ssam_node_root, &ssam_node_bat_ac, &ssam_node_bat_main,
@@ -289,6 +289,22 @@ static const struct software_node *ssam_node_group_sls[] = { NULL, }; +/* Devices for Surface Laptop Studio 2. */ +static const struct software_node *ssam_node_group_sls2[] = { + &ssam_node_root, + &ssam_node_bat_ac, + &ssam_node_bat_main, + &ssam_node_tmp_perf_profile_with_fan, + &ssam_node_tmp_sensors, + &ssam_node_fan_speed, + &ssam_node_pos_tablet_switch, + &ssam_node_hid_sam_keyboard, + &ssam_node_hid_sam_penstash, + &ssam_node_hid_sam_sensors, + &ssam_node_hid_sam_ucm_ucsi, +NULL , +}; +/* Devices for Surface Laptop Go. */ static const struct software_node *ssam_node_group_slg1[] = { &ssam_node_root,
@@ -401,8 +417,11 @@ static const struct acpi_device_id ssam_platform_hub_match[] = {/* Surface Laptop Go 3 */ { "MSHW0440", (unsigned long)ssam_node_group_slg1 }, -/* Surface Laptop Studio */ - { "MSHW0123", (unsigned long)ssam_node_group_sls }, +/* Surface Laptop Studio 1 */ + { "MSHW0123", (unsigned long)ssam_node_group_sls1 }, + +/* Surface Laptop Studio 2 */ + { "MSHW0360", (unsigned long)ssam_node_group_sls2 }, { }, };
Signature · 1 line
2.46.0
Maximilian Luz
maintainerPATCH 4/5 platform/surface: aggregator_registry: Add fan and thermal sensor support for Surface Laptop 5
In reply to Maximilian LuzThe EC on the Surface Laptop 5 exposes the fan interface. With the recently introduced driver for it, we can now also enable it here. In addition, also enable the thermal sensor interface.
--- drivers/platform/surface/surface_aggregator_registry.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/platform/surface/surface_aggregator_registry.c +3 -1
@@ -265,7 +265,9 @@ static const struct software_node *ssam_node_group_sl5[] = { &ssam_node_root, &ssam_node_bat_ac, &ssam_node_bat_main, - &ssam_node_tmp_perf_profile, + &ssam_node_tmp_perf_profile_with_fan, + &ssam_node_tmp_sensors, + &ssam_node_fan_speed, &ssam_node_hid_main_keyboard, &ssam_node_hid_main_touchpad, &ssam_node_hid_main_iid5,
Signature · 1 line
2.46.0
Maximilian Luz
maintainerPATCH 5/5 platform/surface: aggregator_registry: Add support for Surface Laptop 6
In reply to Maximilian LuzAdd SAM client device nodes for the Surface Laptop Studio 6 (SL6). The SL6 is similar to the SL5, with the typical battery/AC, platform profile, and HID nodes. It also has support for the newly supported fan interface.
--- .../surface/surface_aggregator_registry.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+)
drivers/platform/surface/surface_aggregator_registry.c +19 -0
@@ -275,6 +275,22 @@ static const struct software_node *ssam_node_group_sl5[] = { NULL, }; +/* Devices for Surface Laptop 6. */ +static const struct software_node *ssam_node_group_sl6[] = { + &ssam_node_root, + &ssam_node_bat_ac, + &ssam_node_bat_main, + &ssam_node_tmp_perf_profile_with_fan, + &ssam_node_tmp_sensors, + &ssam_node_fan_speed, + &ssam_node_hid_main_keyboard, + &ssam_node_hid_main_touchpad, + &ssam_node_hid_main_iid5, + &ssam_node_hid_sam_sensors, + &ssam_node_hid_sam_ucm_ucsi, +NULL , +}; +/* Devices for Surface Laptop Studio 1. */ static const struct software_node *ssam_node_group_sls1[] = { &ssam_node_root,
@@ -410,6 +426,9 @@ static const struct acpi_device_id ssam_platform_hub_match[] = {/* Surface Laptop 5 */ { "MSHW0350", (unsigned long)ssam_node_group_sl5 }, +/* Surface Laptop 6 */ + { "MSHW0530", (unsigned long)ssam_node_group_sl6 }, +/* Surface Laptop Go 1 */ { "MSHW0118", (unsigned long)ssam_node_group_slg1 },
Signature · 1 line
2.46.0
Ilpo Järvinen
maintainerQuoted 11 lines · Maximilian Luz
This series is basically a collection of SAM device enablement patches, for which I only now found the time to clean them up end send them in. It adds Surface SAM support (enabling battery status, keyboard, touchpad, and more) for the following devices:
- Surface Pro 10
- Surface Laptop Go 3
- Surface Laptop Studio 2
- Surface Laptop 6[...]
Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while.
The list of commits applied:
[1/5] platform/surface: aggregator_registry: Add Support for Surface Pro 10
commit: 9c8e022567bbec53bee8ae75c44b3d6cd2080d42
[2/5] platform/surface: aggregator_registry: Add support for Surface Laptop Go 3
commit: ed235163c3f02329d5e37ed4485bbc39ed2568d4
[3/5] platform/surface: aggregator_registry: Add support for Surface Laptop Studio 2
commit: 28d04b4a2cc20981c95787f9c449e6fc51d904f9
[4/5] platform/surface: aggregator_registry: Add fan and thermal sensor support for Surface Laptop 5
commit: 002adda09bc1c983c75c82a7e12285c7423aec31
[5/5] platform/surface: aggregator_registry: Add support for Surface Laptop 6
commit: 99ae7b9ba047ad029a0a23b2bd51608ce79c8e97--
i.