Skip to contentSkip to conversation

selftests/net/pmtu.sh: Fix typo in error message

PATCH Applied Abhash Jha 5 participants 8 messages Aug 14, 2024 – Aug 16, 2024

Subsystems (3)
lore
Share & tools
lore

Abhash Jha

author
#0 lore raw

PATCH 1/1 selftests/net/pmtu.sh: Fix typo in error message

The word 'expected' was spelled as 'exepcted'.
Fixed the typo in this patch.

---
 tools/testing/selftests/net/pmtu.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/pmtu.sh +1 -1
index cfc849580..62eceb385 100755
@@ -1347,7 +1347,7 @@ test_pmtu_ipvX_over_bridged_vxlanY_or_geneveY_exception() {
 		size=$(du -sb $tmpoutfile)
 		size=${size%%/tmp/*}
 
-		[ $size -ne 1048576 ] && err "File size $size mismatches exepcted value in locally bridged vxlan test" && return 1
+		[ $size -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1
 	done
 
 	rm -f "$tmpoutfile"
Signature · 1 line
2.43.0
#1 lore raw

Hi Abhash,

You need add target repo for the patch. e.g. [PATCH net] selftests...

Quoted 3 lines · Abhash Jha

The word 'expected' was spelled as 'exepcted'.
Fixed the typo in this patch.

Here you need to add the fixes tag. e.g.

Fixes 136a1b434bbb ("selftests: net: test vxlan pmtu exceptions with tcp")
Quoted 21 lines
---
 tools/testing/selftests/net/pmtu.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/net/pmtu.sh +1 -1
index cfc849580..62eceb385 100755
@@ -1347,7 +1347,7 @@ test_pmtu_ipvX_over_bridged_vxlanY_or_geneveY_exception() {
 		size=$(du -sb $tmpoutfile)
 		size=${size%%/tmp/*}
 
-		[ $size -ne 1048576 ] && err "File size $size mismatches exepcted value in locally bridged vxlan test" && return 1
+		[ $size -ne 1048576 ] && err "File size $size mismatches expected value in locally bridged vxlan test" && return 1
 	done
 
 	rm -f "$tmpoutfile"
Signature · 1 line
2.43.0
author
#3 lore raw
Quoted 5 lines

I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.

Hi Simon,
Thanks for the review, Should I still send the patch again with the fixes tag and the target repo for the patch as suggested by [email protected]. Or is it fine for now.

Regards,
Abhash

reviewer
#4 lore raw
Quoted 10 lines · Abhash jha
Quoted 5 lines

I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.

Hi Simon,
Thanks for the review, Should I still send the patch again with the fixes tag and the target repo for the patch as suggested by [email protected]. Or is it fine for now.

Sorry for sending my response before I noticed Hangbin's - I didn't mean to send conflicting information.

TBH, I'm not entirely sure this is a fix, for which my rule of thumb is that it resolves a user-visible bug. But if you believe it is, then please follow Hangbin's advice.

maintainer
#5 lore raw
Quoted 12 lines · On Thu, 15 Aug 2024 18:45:08 +0100 Simon Horman wrote:
Quoted 10 lines · Abhash jha
Quoted 5 lines

I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.

Hi Simon,
Thanks for the review, Should I still send the patch again with the fixes tag and the target repo for the patch as suggested by [email protected]. Or is it fine for now.

Quoted 5 lines

Sorry for sending my response before I noticed Hangbin's - I didn't mean to send conflicting information.

TBH, I'm not entirely sure this is a fix, for which my rule of thumb is that it resolves a user-visible bug.

+1, same feeling here, I'll apply as is.

#6 lore raw
Quoted 13 lines · Jakub Kicinski
Quoted 12 lines · On Thu, 15 Aug 2024 18:45:08 +0100 Simon Horman wrote:
Quoted 10 lines · Abhash jha
Quoted 5 lines

I agree with the correctness of this change. And I verified that with this patch applied, coedspell only flags false positives in this file.

Hi Simon,
Thanks for the review, Should I still send the patch again with the fixes tag and the target repo for the patch as suggested by [email protected]. Or is it fine for now.

Quoted 7 lines
Quoted 5 lines

Sorry for sending my response before I noticed Hangbin's - I didn't mean to send conflicting information.

TBH, I'm not entirely sure this is a fix, for which my rule of thumb is that it resolves a user-visible bug.

+1, same feeling here, I'll apply as is.

Thanks, good to know this.

Hangbin

#7 lore raw
In reply to Abhash Jha
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Wed, 14 Aug 2024 23:01:21 +0530 you wrote:

The word 'expected' was spelled as 'exepcted'.
Fixed the typo in this patch.

---
 tools/testing/selftests/net/pmtu.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- selftests/net/pmtu.sh: Fix typo in error message

    https://git.kernel.org/netdev/net-next/c/e7d731326ef0

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html