Skip to contentSkip to conversation

igb: cope with large MAX_SKB_FRAGS

PATCH Applied Corinna Vinschen 3 participants 3 messages Aug 16, 2024 – Aug 21, 2024

Subsystems (3)

v2 of 3 Applied 1/1 Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 igb: cope with large MAX_SKB_FRAGS

From: Paolo Abeni <[email protected]>

Sabrina reports that the igb driver does not cope well with large MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload corruption on TX.

An easy reproducer is to run ssh to connect to the machine. With MAX_SKB_FRAGS=17 it works, with MAX_SKB_FRAGS=45 it fails. This has been reported originally in
https://bugzilla.redhat.com/show_bug.cgi?id=2265320

The root cause of the issue is that the driver does not take into account properly the (possibly large) shared info size when selecting the ring layout, and will try to fit two packets inside the same 4K page even when the 1st fraglist will trump over the 2nd head.

Address the issue by checking if 2K buffers are insufficient.

---
 drivers/net/ethernet/intel/igb/igb_main.c | 1 +
 1 file changed, 1 insertion(+)

v2: utilize IGB_2K_TOO_SMALL_WITH_PADDING

drivers/net/ethernet/intel/igb/igb_main.c +1 -0
index 11be39f435f3..33a42b4c21e0 100644
@@ -4808,6 +4808,7 @@ static void igb_set_rx_buffer_len(struct igb_adapter *adapter,
 
 #if (PAGE_SIZE < 8192)
 	if (adapter->max_frame_size > IGB_MAX_FRAME_BUILD_SKB ||
+	    IGB_2K_TOO_SMALL_WITH_PADDING ||
 	    rd32(E1000_RCTL) & E1000_RCTL_SBP)
 		set_ring_uses_large_buffer(rx_ring);
 #endif
Signature · 1 line
2.45.2
#1 lore raw
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 6 lines · On Fri, 16 Aug 2024 17:20:34 +0200 you wrote:

From: Paolo Abeni <[email protected]>

Sabrina reports that the igb driver does not cope well with large MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload corruption on TX.

Quoted 6 lines

An easy reproducer is to run ssh to connect to the machine. With MAX_SKB_FRAGS=17 it works, with MAX_SKB_FRAGS=45 it fails. This has been reported originally in
https://bugzilla.redhat.com/show_bug.cgi?id=2265320

[...]

Here is the summary with links:
- [net,v2] igb: cope with large MAX_SKB_FRAGS

    https://git.kernel.org/netdev/net/c/8aba27c4a502

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
#2 lore raw
Quoted 17 lines

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Fri, 16 Aug 2024 17:20:34 +0200 you wrote:

From: Paolo Abeni <[email protected]>

Sabrina reports that the igb driver does not cope well with large MAX_SKB_FRAG values: setting MAX_SKB_FRAG to 45 causes payload corruption on TX.

An easy reproducer is to run ssh to connect to the machine. With MAX_SKB_FRAGS=17 it works, with MAX_SKB_FRAGS=45 it fails. This has been reported originally in
https://bugzilla.redhat.com/show_bug.cgi?id=2265320

Eh, I missed giving my reviewed-by tag. FWIW thanks for this v2!

Quoted 12 lines
Quoted 2 lines

[...]

Here is the summary with links:
- [net,v2] igb: cope with large MAX_SKB_FRAGS

    https://git.kernel.org/netdev/net/c/8aba27c4a502

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html