Skip to contentSkip to conversation

net: dsa: b53: Use dev_err_probe()

PATCH Applied Florian Fainelli 3 participants 3 messages Aug 20, 2024 – Aug 21, 2024

Subsystems (4)
lore
Share & tools
lore

Florian Fainelli

author maintainer
#0 lore raw

PATCH 1/1 net: dsa: b53: Use dev_err_probe()

Rather than print an error even when we get -EPROBE_DEFER, use dev_err_probe() to filter out those messages.

---
 drivers/net/dsa/b53/b53_mdio.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/net/dsa/b53/b53_mdio.c +3 -4
index 897e5e8b3d69..31d070bf161a 100644
@@ -343,10 +343,9 @@ static int b53_mdio_probe(struct mdio_device *mdiodev)
 	dev_set_drvdata(&mdiodev->dev, dev);
 
 	ret = b53_switch_register(dev);
-	if (ret) {
-		dev_err(&mdiodev->dev, "failed to register switch: %i\n", ret);
-		return ret;
-	}
+	if (ret)
+		return dev_err_probe(&mdiodev->dev, ret,
+				     "failed to register switch\n");
 
 	return ret;
 }
Signature · 1 line
2.34.1
#2 lore raw
In reply to Florian Fainelli
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Mon, 19 Aug 2024 17:44:35 -0700 you wrote:

Rather than print an error even when we get -EPROBE_DEFER, use dev_err_probe() to filter out those messages.

---
 drivers/net/dsa/b53/b53_mdio.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Here is the summary with links:
- [net-next] net: dsa: b53: Use dev_err_probe()

    https://git.kernel.org/netdev/net-next/c/4d36b2b1dea4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html