a2dp: Fix connection error message
PATCH 1/1 a2dp: Fix connection error message
When trying to connect to a phone which has removed the pairing, the DBus error message is:
- if A2DP only is supported: br-connection-key-missing (EBADE)
- if HFP only is supported: br-connection-refused (ECONNREFUSED)
- if both are supported: br-connection-unknown, while the trace shows ECONNREFUSED in avdtp_connect_cb()
This patch allows to return the correct error message.
--- profiles/audio/a2dp.c | 1 + 1 file changed, 1 insertion(+)
profiles/audio/a2dp.c +1 -0
@@ -326,6 +326,7 @@ static int error_to_errno(struct avdtp_error *err)case EHOSTDOWN :case ECONNABORTED :case EBADE : +case ECONNREFUSED :return -perr;default :/*
Signature · 1 line
2.34.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=881647
---Test result---
Test Summary:
CheckPatch PASS 0.46 seconds GitLint PASS 0.33 seconds BuildEll PASS 25.96 seconds BluezMake PASS 1707.34 seconds MakeCheck FAIL 12.89 seconds MakeDistcheck FAIL 162.20 seconds CheckValgrind FAIL 255.70 seconds CheckSmatch PASS 360.53 seconds bluezmakeextell PASS 122.94 seconds IncrementalBuild PASS 1469.17 seconds ScanBuild WARNING 1060.72 seconds
Details
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:
make[3]: *** [Makefile:11766: test-suite.log] Error 1 make[2]: *** [Makefile:11874: check-TESTS] Error 2 make[1]: *** [Makefile:12303: check-am] Error 2
make: *** [Makefile:12305: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:
Package cups was not found in the pkg-config search path. Perhaps you should add the directory containing `cups.pc' to the PKG_CONFIG_PATH environment variable
No package 'cups' found
make[4]: *** [Makefile:11766: test-suite.log] Error 1 make[3]: *** [Makefile:11874: check-TESTS] Error 2 make[2]: *** [Makefile:12303: check-am] Error 2 make[1]: *** [Makefile:12305: check] Error 2
make: *** [Makefile:12226: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:
tools/mgmt-tester.c: In function ‘main’:tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12725 | int main(int argc, char *argv[])
| ^~~~
make[3]: *** [Makefile:11766: test-suite.log] Error 1 make[2]: *** [Makefile:11874: check-TESTS] Error 2 make[1]: *** [Makefile:12303: check-am] Error 2
make: *** [Makefile:12305: check] Error 2
##############################
Test: ScanBuild - WARNING
Desc: Run Scan Build
Output:profiles/audio/a2dp.c:371:8: warning: Use of memory after it is freed
if (!cb->resume_cb)
^~~~~~~~~~~~~1 warning generated.
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 8 lines · On Wed, 21 Aug 2024 09:57:14 +0200 you wrote:
When trying to connect to a phone which has removed the pairing, the DBus error message is:
- if A2DP only is supported: br-connection-key-missing (EBADE)
- if HFP only is supported: br-connection-refused (ECONNREFUSED)
- if both are supported: br-connection-unknown, while the trace shows ECONNREFUSED inavdtp_connect_cb()[...]
Here is the summary with links:
- [BlueZ] a2dp: Fix connection error message
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a6ac17f0e393
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html