Skip to contentSkip to conversation

netpoll: do not export netpoll_poll_[disable|enable]()

PATCH Applied Eric Dumazet 3 participants 3 messages Aug 20, 2024 – Aug 22, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netpoll: do not export netpoll_poll_[disable|enable]()

netpoll_poll_disable() and netpoll_poll_enable() are only used from core networking code, there is no need to export them.

---
 net/core/netpoll.c | 2 --
 1 file changed, 2 deletions(-)
net/core/netpoll.c +0 -2
index a58ea724790ce772004f4053afab0f7da458aff1..cff1f89719b6d6ba66b4687db03596d8362b6571 100644
@@ -228,7 +228,6 @@ void netpoll_poll_disable(struct net_device *dev)
 		down(&ni->dev_lock);
 	srcu_read_unlock(&netpoll_srcu, idx);
 }
-EXPORT_SYMBOL(netpoll_poll_disable);
 
 void netpoll_poll_enable(struct net_device *dev)
 {
@@ -239,7 +238,6 @@ void netpoll_poll_enable(struct net_device *dev)
 		up(&ni->dev_lock);
 	rcu_read_unlock();
 }
-EXPORT_SYMBOL(netpoll_poll_enable);
 
 static void refill_skbs(void)
 {
Signature · 1 line
2.46.0.184.g6999bdac58-goog
#2 lore raw
In reply to Eric Dumazet
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 7 lines · On Tue, 20 Aug 2024 16:20:53 +0000 you wrote:

netpoll_poll_disable() and netpoll_poll_enable() are only used from core networking code, there is no need to export them.

---
 net/core/netpoll.c | 2 --
 1 file changed, 2 deletions(-)

Here is the summary with links:
- [net] netpoll: do not export netpoll_poll_[disable|enable]()

    https://git.kernel.org/netdev/net/c/007d4271a5f1

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html