f2fs: fix to wait page writeback before setting gcing flag
Chao Yu
maintainerPATCH 1/1 f2fs: fix to wait page writeback before setting gcing flag
Soft IRQ Thread
- f2fs_write_end_io
- f2fs_defragment_range
- set_page_private_gcing
- type = WB_DATA_TYPE(page, false);
: assign type w/ F2FS_WB_CP_DATA
due to page_private_gcing() is true
- dec_page_count() w/ wrong type
- end_page_writeback()
Value of F2FS_WB_CP_DATA reference count may become negative under above race condition, the root cause is we missed to wait page writeback before setting gcing page private flag, let's fix it.
--- fs/f2fs/file.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/f2fs/file.c +4 -0
@@ -2817,6 +2817,8 @@ static int f2fs_defragment_range(struct f2fs_sb_info *sbi, goto clear_out; } +f2fs_wait_on_page_writeback (page,DATA , true, true); +set_page_dirty (page);set_page_private_gcing (page);f2fs_put_page (page,1 );
@@ -4217,6 +4219,8 @@ static int redirty_blocks(struct inode *inode, pgoff_t page_idx, int len)/* It will never fail, when page has pinned above */ f2fs_bug_on (F2FS_I_SB (inode), !page); +f2fs_wait_on_page_writeback (page,DATA , true, true); +set_page_dirty (page);set_page_private_gcing (page);f2fs_put_page (page,1 );
Signature · 1 line
2.40.1
This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim <[email protected]>:
Hello:
This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:
Quoted 11 lines · On Mon, 12 Aug 2024 22:12:42 +0800 you wrote:
Soft IRQ Thread
-f2fs_write_end_io
-f2fs_defragment_range
-set_page_private_gcing
- type =WB_DATA_TYPE(page, false);
: assign type w/F2FS_WB_CP_DATA
due topage_private_gcing()is true
-dec_page_count()w/ wrong type
-end_page_writeback()[...]
Here is the summary with links:
- [f2fs-dev] f2fs: fix to wait page writeback before setting gcing flag
https://git.kernel.org/jaegeuk/f2fs/c/a4d7f2b3238f
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html