i2c: designware: Group all DesignWare drivers under a single option
Subsystems (10)
v2 cover i2c: designware: Group all DesignWare drivers under a single option
Hi guys,
This is a proposal for Kconfig improvement regarding the Synopsys DesignWare I2C adapter driver.
Changes since v1:
There was one driver that selects I2C_DESIGNWARE_PLATFORM in its Kconfig which causes an error because I2C_DESIGNWARE_CORE is not selected.
The drivers Kconfig I'm proposing that we fix by using "depends on" instead of "select". There are also a number of defconfigs that enable I2C_DESIGNWARE_PLATFORM that now need to enable I2C_DESIGNWARE_CORE.
The original patch:
https://lore.kernel.org/linux-i2c/[email protected]/
thanks,
Heikki Krogerus (7):
ARC: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
ARM: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
arm64: defconfig: enable I2C_DESIGNWARE_CORE with
I2C_DESIGNWARE_PLATFORM
mips: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
RISC-V: configs: enable I2C_DESIGNWARE_CORE with
I2C_DESIGNWARE_PLATFORM
net: txgbe: Fix I2C Kconfig dependencies
i2c: designware: Group all DesignWare drivers under a single option
arch/arc/configs/axs101_defconfig | 1 + arch/arc/configs/axs103_defconfig | 1 + arch/arc/configs/axs103_smp_defconfig | 1 + arch/arc/configs/tb10x_defconfig | 1 + arch/arm/configs/hisi_defconfig | 1 + arch/arm/configs/multi_v7_defconfig | 1 + arch/arm/configs/pxa_defconfig | 1 + arch/arm/configs/socfpga_defconfig | 1 + arch/arm/configs/spear13xx_defconfig | 1 + arch/arm/configs/spear3xx_defconfig | 1 + arch/arm/configs/spear6xx_defconfig | 1 + arch/arm64/configs/defconfig | 1 + arch/mips/configs/generic/board-ocelot.config | 1 + arch/riscv/configs/defconfig | 1 + arch/riscv/configs/nommu_k210_defconfig | 1 + .../riscv/configs/nommu_k210_sdcard_defconfig | 1 + drivers/i2c/busses/Kconfig | 29 ++++++++++++------- drivers/net/ethernet/wangxun/Kconfig | 3 +- 18 files changed, 35 insertions(+), 13 deletions(-)
Signature · 1 line
2.45.2
PATCH v2 1/7 ARC: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
The dependency handling of the Synopsys DesignWare I2C adapter drivers is going to be changed so that the glue drivers for the PCI and platform buses depend on I2C_DESIGNWARE_CORE.
--- arch/arc/configs/axs101_defconfig | 1 + arch/arc/configs/axs103_defconfig | 1 + arch/arc/configs/axs103_smp_defconfig | 1 + arch/arc/configs/tb10x_defconfig | 1 + 4 files changed, 4 insertions(+)
arch/arc/configs/axs101_defconfig +1 -0
@@ -66,6 +66,7 @@ CONFIG_SERIAL_OF_PLATFORM=y # CONFIG_HW_RANDOM is not set CONFIG_I2C=y CONFIG_I2C_CHARDEV=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y # CONFIG_HWMON is not set CONFIG_DRM=m
arch/arc/configs/axs103_defconfig +1 -0
@@ -66,6 +66,7 @@ CONFIG_SERIAL_OF_PLATFORM=y # CONFIG_HW_RANDOM is not set CONFIG_I2C=y CONFIG_I2C_CHARDEV=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y # CONFIG_HWMON is not set CONFIG_FB=y
arch/arc/configs/axs103_smp_defconfig +1 -0
@@ -66,6 +66,7 @@ CONFIG_SERIAL_OF_PLATFORM=y # CONFIG_HW_RANDOM is not set CONFIG_I2C=y CONFIG_I2C_CHARDEV=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y # CONFIG_HWMON is not set CONFIG_DRM=m
arch/arc/configs/tb10x_defconfig +1 -0
@@ -60,6 +60,7 @@ CONFIG_SERIAL_8250_DW=y # CONFIG_HW_RANDOM is not set CONFIG_I2C=y # CONFIG_I2C_COMPAT is not set +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_GPIO_SYSFS=y # CONFIG_HWMON is not set
Signature · 1 line
2.45.2
PATCH v2 2/7 ARM: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
In reply to Heikki KrogerusThe dependency handling of the Synopsys DesignWare I2C adapter drivers is going to be changed so that the glue drivers for the PCI and platform buses depend on I2C_DESIGNWARE_CORE.
--- arch/arm/configs/hisi_defconfig | 1 + arch/arm/configs/multi_v7_defconfig | 1 + arch/arm/configs/pxa_defconfig | 1 + arch/arm/configs/socfpga_defconfig | 1 + arch/arm/configs/spear13xx_defconfig | 1 + arch/arm/configs/spear3xx_defconfig | 1 + arch/arm/configs/spear6xx_defconfig | 1 + 7 files changed, 7 insertions(+)
arch/arm/configs/hisi_defconfig +1 -0
@@ -43,6 +43,7 @@ CONFIG_SERIAL_8250_DW=y CONFIG_SERIAL_OF_PLATFORM=y CONFIG_SERIAL_AMBA_PL011=y CONFIG_SERIAL_AMBA_PL011_CONSOLE=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y CONFIG_SPI_PL022=y
arch/arm/configs/multi_v7_defconfig +1 -0
@@ -413,6 +413,7 @@ CONFIG_I2C_AT91=m CONFIG_I2C_BCM2835=y CONFIG_I2C_CADENCE=y CONFIG_I2C_DAVINCI=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_DIGICOLOR=m CONFIG_I2C_EMEV2=m
arch/arm/configs/pxa_defconfig +1 -0
@@ -277,6 +277,7 @@ CONFIG_HW_RANDOM=y CONFIG_I2C_CHARDEV=m CONFIG_I2C_MUX_PCA954x=m CONFIG_I2C_MUX_PINCTRL=m +CONFIG_I2C_DESIGNWARE_CORE=m CONFIG_I2C_DESIGNWARE_PLATFORM=m CONFIG_I2C_GPIO=y CONFIG_I2C_PXA_SLAVE=y
arch/arm/configs/socfpga_defconfig +1 -0
@@ -83,6 +83,7 @@ CONFIG_SERIAL_8250_RUNTIME_UARTS=2 CONFIG_SERIAL_8250_DW=y CONFIG_I2C=y CONFIG_I2C_CHARDEV=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y CONFIG_SPI_CADENCE_QUADSPI=y
arch/arm/configs/spear13xx_defconfig +1 -0
@@ -62,6 +62,7 @@ CONFIG_SERIAL_AMBA_PL011_CONSOLE=y # CONFIG_HW_RANDOM is not set CONFIG_RAW_DRIVER=y CONFIG_I2C=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y CONFIG_SPI_PL022=y
arch/arm/configs/spear3xx_defconfig +1 -0
@@ -42,6 +42,7 @@ CONFIG_SERIAL_AMBA_PL011_CONSOLE=y # CONFIG_HW_RANDOM is not set CONFIG_RAW_DRIVER=y CONFIG_I2C=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y CONFIG_SPI_PL022=y
arch/arm/configs/spear6xx_defconfig +1 -0
@@ -33,6 +33,7 @@ CONFIG_STMMAC_ETH=y CONFIG_SERIAL_AMBA_PL011=y CONFIG_SERIAL_AMBA_PL011_CONSOLE=y CONFIG_I2C=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y CONFIG_SPI_PL022=y
Signature · 1 line
2.45.2
PATCH v2 3/7 arm64: defconfig: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
In reply to Heikki KrogerusThe dependency handling of the Synopsys DesignWare I2C adapter drivers is going to be changed so that the glue drivers for the PCI and platform buses depend on I2C_DESIGNWARE_CORE.
--- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)
arch/arm64/configs/defconfig +1 -0
@@ -518,6 +518,7 @@ CONFIG_I2C_MUX=y CONFIG_I2C_MUX_PCA954x=y CONFIG_I2C_BCM2835=m CONFIG_I2C_CADENCE=m +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_GPIO=m CONFIG_I2C_IMX=y
Signature · 1 line
2.45.2
PATCH v2 4/7 mips: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
In reply to Heikki KrogerusThe dependency handling of the Synopsys DesignWare I2C adapter drivers is going to be changed so that the glue drivers for the PCI and platform buses depend on I2C_DESIGNWARE_CORE.
--- arch/mips/configs/generic/board-ocelot.config | 1 + 1 file changed, 1 insertion(+)
arch/mips/configs/generic/board-ocelot.config +1 -0
@@ -31,6 +31,7 @@ CONFIG_MICROSEMI_PHY=y CONFIG_I2C=y CONFIG_I2C_CHARDEV=y CONFIG_I2C_MUX=y +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y
Signature · 1 line
2.45.2
PATCH v2 5/7 RISC-V: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
In reply to Heikki KrogerusThe dependency handling of the Synopsys DesignWare I2C adapter drivers is going to be changed so that the glue drivers for the PCI and platform buses depend on I2C_DESIGNWARE_CORE.
--- arch/riscv/configs/defconfig | 1 + arch/riscv/configs/nommu_k210_defconfig | 1 + arch/riscv/configs/nommu_k210_sdcard_defconfig | 1 + 3 files changed, 3 insertions(+)
arch/riscv/configs/defconfig +1 -0
@@ -157,6 +157,7 @@ CONFIG_HW_RANDOM_VIRTIO=y CONFIG_HW_RANDOM_JH7110=m CONFIG_I2C=y CONFIG_I2C_CHARDEV=m +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_MV64XXX=m CONFIG_I2C_RIIC=y
arch/riscv/configs/nommu_k210_defconfig +1 -0
@@ -58,6 +58,7 @@ CONFIG_I2C=y # CONFIG_I2C_COMPAT is not set CONFIG_I2C_CHARDEV=y # CONFIG_I2C_HELPER_AUTO is not set +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y # CONFIG_SPI_MEM is not set
arch/riscv/configs/nommu_k210_sdcard_defconfig +1 -0
@@ -50,6 +50,7 @@ CONFIG_DEVTMPFS_MOUNT=y CONFIG_I2C=y CONFIG_I2C_CHARDEV=y # CONFIG_I2C_HELPER_AUTO is not set +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y # CONFIG_SPI_MEM is not set
Signature · 1 line
2.45.2
Re: [PATCH v2 5/7] RISC-V: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
Quoted 45 lines · On Tue, 03 Sep 2024 07:25:04 PDT (-0700), [email protected] wrote:
The dependency handling of the Synopsys DesignWare I2C adapter drivers is going to be changed so that the glue drivers for the PCI and platform buses depend on
I2C_DESIGNWARE_CORE.Cc Paul Walmsley <[email protected]>Cc Palmer Dabbelt <[email protected]>Cc Albert Ou <[email protected]>Signed-off-by Heikki Krogerus <[email protected]>--- arch/riscv/configs/defconfig | 1 + arch/riscv/configs/nommu_k210_defconfig | 1 + arch/riscv/configs/nommu_k210_sdcard_defconfig | 1 + 3 files changed, 3 insertions(+)arch/riscv/configs/defconfig +1
-0@@ -157,6 +157,7 @@ CONFIG_HW_RANDOM_VIRTIO=y CONFIG_HW_RANDOM_JH7110=m CONFIG_I2C=y CONFIG_I2C_CHARDEV=m +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_I2C_MV64XXX=m CONFIG_I2C_RIIC=yarch/riscv/configs/nommu_k210_defconfig +1
-0@@ -58,6 +58,7 @@ CONFIG_I2C=y # CONFIG_I2C_COMPAT is not set CONFIG_I2C_CHARDEV=y # CONFIG_I2C_HELPER_AUTO is not set +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y # CONFIG_SPI_MEM is not setarch/riscv/configs/nommu_k210_sdcard_defconfig +0
-0
arch/riscv/configs/nommu_k210_sdcard_defconfig CONFIG_DEVTMPFS_MOUNT=y · line 56
Quoted 7 lines
arch/riscv/configs/nommu_k210_sdcard_defconfig +1
-0@@ -50,6 +50,7 @@ CONFIG_DEVTMPFS_MOUNT=y CONFIG_I2C=y CONFIG_I2C_CHARDEV=y # CONFIG_I2C_HELPER_AUTO is not set +CONFIG_I2C_DESIGNWARE_CORE=y CONFIG_I2C_DESIGNWARE_PLATFORM=y CONFIG_SPI=y # CONFIG_SPI_MEM is not set
(based on the rest of the thread I'm assuming you're taking these all together, which seems saner to me)
PATCH v2 6/7 net: txgbe: Fix I2C Kconfig dependencies
In reply to Heikki KrogerusThe dependency handling of the Synopsys DesignWare I2C adapter drivers is going to be changed so that the glue drivers for the platform and PCI buses depend on I2C_DESIGNWARE_CORE. Right now this driver prevents that update because it selects I2C_DESIGNWARE_PLATFORM.
To make the dependency on I2C_DESIGNWARE_PLATFORM consistent with the other drivers in kernel that depend on it, and allow the dependency handling of the Synopsys DesignWare I2C drivers to be updated, change the "select" into "depends on".
--- drivers/net/ethernet/wangxun/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/ethernet/wangxun/Kconfig +1 -2
@@ -41,10 +41,9 @@ config TXGBE tristate "Wangxun(R) 10GbE PCI Express adapters support" depends on PCI depends on COMMON_CLK + depends on I2C_DESIGNWARE_PLATFORM select MARVELL_10G_PHY select REGMAP - select I2C - select I2C_DESIGNWARE_PLATFORM select PHYLINK select HWMON if TXGBE=y select SFP
Signature · 1 line
2.45.2
PATCH v2 7/7 i2c: designware: Group all DesignWare drivers under a single option
In reply to Heikki KrogerusThere are quite a few drivers and options for the DesignWare I2C adapter in the Kconfig. Grouping all of them under the I2C_DESIGNWARE_CORE. That makes the menuconfig a bit more easier to understand.
--- drivers/i2c/busses/Kconfig | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-)
drivers/i2c/busses/Kconfig +18 -11
@@ -559,28 +559,33 @@ config I2C_DAVINCI For details please see http://www.ti.com/davinci config I2C_DESIGNWARE_CORE - tristate + tristate "Synopsys DesignWare I2C adapter" select REGMAP + help + This option enables support for the Synopsys DesignWare I2C adapter. + This driver includes support for the I2C host on the Synopsys + Designware I2C adapter. + + To compile the driver as a module, choose M here: the module will be + called i2c-designware-core. + +if I2C_DESIGNWARE_CORE config I2C_DESIGNWARE_SLAVE bool "Synopsys DesignWare Slave" - depends on I2C_DESIGNWARE_CORE select I2C_SLAVE help If you say yes to this option, support will be included for the Synopsys DesignWare I2C slave adapter. - This is not a standalone module, this module compiles together with - i2c-designware-core. - config I2C_DESIGNWARE_PLATFORM - tristate "Synopsys DesignWare Platform" + tristate "Synopsys DesignWare Platform driver" depends on (ACPI && COMMON_CLK) || !ACPI - select I2C_DESIGNWARE_CORE select MFD_SYSCON if MIPS_BAIKAL_T1 + default I2C_DESIGNWARE_CORE help If you say yes to this option, support will be included for the - Synopsys DesignWare I2C adapter. + Synopsys DesignWare I2C adapters on the platform bus. This driver can also be built as a module. If so, the module will be called i2c-designware-platform.
@@ -613,17 +618,19 @@ config I2C_DESIGNWARE_BAYTRAIL a BayTrail system using the AXP288. config I2C_DESIGNWARE_PCI - tristate "Synopsys DesignWare PCI" + tristate "Synopsys DesignWare PCI driver" depends on PCI - select I2C_DESIGNWARE_CORE select I2C_CCGX_UCSI help If you say yes to this option, support will be included for the - Synopsys DesignWare I2C adapter. Only master mode is supported. + Synopsys DesignWare I2C adapters on the PCI bus. Only master mode is + supported. This driver can also be built as a module. If so, the module will be called i2c-designware-pci. +endif + config I2C_DIGICOLOR tristate "Conexant Digicolor I2C driver" depends on ARCH_DIGICOLOR || COMPILE_TEST
Signature · 1 line
2.45.2
Andi Shyti
maintainerHi Heikki,
Quoted 6 lines · Heikki Krogerus
There are quite a few drivers and options for the DesignWare I2C adapter in the
Kconfig. Grouping all of them under theI2C_DESIGNWARE_CORE. That makes the menuconfig a bit more easier to understand.Signed-off-by Heikki Krogerus <[email protected]>
Thanks for your patch, I can take this only after the other patches have been taken in.
Andi
Quoted 8 lines · Andi Shyti
Hi Heikki,
Quoted 5 lines · Heikki Krogerus
There are quite a few drivers and options for the DesignWare I2C adapter in the
Kconfig. Grouping all of them under theI2C_DESIGNWARE_CORE. That makes the menuconfig a bit more easier to understand.
Quoted 4 lines
Quoted 1 line
Signed-off-by Heikki Krogerus <[email protected]>Thanks for your patch, I can take this only after the other patches have been taken in.
I assume then that you're expecting the prereqs to go through the various arch trees? Is this not trivial enough that you could chuck it on a dedicated branch in your tree and if, for some reason, there's a non-trivial conflict the affected could pull it in?
Andi Shyti
maintainerHi Conor,
Quoted 11 lines · Conor Dooley
Quoted 10 lines · Andi Shyti
Hi Heikki,
Quoted 6 lines · Heikki Krogerus
There are quite a few drivers and options for the DesignWare I2C adapter in the
Kconfig. Grouping all of them under theI2C_DESIGNWARE_CORE. That makes the menuconfig a bit more easier to understand.Signed-off-by Heikki Krogerus <[email protected]>
Quoted 7 lines
Quoted 2 lines
Thanks for your patch, I can take this only after the other patches have been taken in.
I assume then that you're expecting the prereqs to go through the various arch trees? Is this not trivial enough that you could chuck it on a dedicated branch in your tree and if, for some reason, there's a non-trivial conflict the affected could pull it in?
Thanks for your advice: considering that cross-domain patches are difficult to handle, I appreciate any suggestion on how to deal with them :-)
Are you suggesting to set these up in a different branch and send a pull request out of that branch?
I don't want here to step into other people branches if they don't ack or express any thought.
Andi
Quoted 17 lines · Andi Shyti
Hi Conor,
Quoted 14 lines · Conor Dooley
Quoted 12 lines · Andi Shyti
Hi Heikki,
Quoted 6 lines · Heikki Krogerus
There are quite a few drivers and options for the DesignWare I2C adapter in the
Kconfig. Grouping all of them under theI2C_DESIGNWARE_CORE. That makes the menuconfig a bit more easier to understand.Signed-off-by Heikki Krogerus <[email protected]>Thanks for your patch, I can take this only after the other patches have been taken in.
Quoted 8 lines
Quoted 4 lines
I assume then that you're expecting the prereqs to go through the various arch trees? Is this not trivial enough that you could chuck it on a dedicated branch in your tree and if, for some reason, there's a non-trivial conflict the affected could pull it in?
Thanks for your advice: considering that cross-domain patches are difficult to handle, I appreciate any suggestion on how to deal with them :-)
It's also helpful if the submitter of a series proposes what path patches should take upstream. I find that people all look at something like this and see "someone else's problem" written all over it, and would be perfectly happy to accept a proposal from a submitter that it all goes via I2C.
Quoted 2 lines
Are you suggesting to set these up in a different branch and send a pull request out of that branch?
What I meant was put them in a dedicated branch (so probably on top of -rc1 or similar) and merge that branch into your for-next branch. If someone then was to run into a non-trivial conflict you could tag the dedicated branch and they could pull it into their tree.
Quoted 2 lines
I don't want here to step into other people branches if they don't ack or express any thought.
Sure, I wouldn't either, but it far from abnormal for driver subsystem maintainer to take these sort of rename/dependency addition patches and the normal path for 3 of the 5 architectures affected here is via Arnd and I figure there's a low probability of the maintainers of those architectures having their feels hurt.
Cheers,
Conor.
Andi Shyti
maintainerQuoted 37 lines · Conor Dooley
Quoted 13 lines · Andi Shyti
Quoted 12 lines · Conor Dooley
Quoted 10 lines · Andi Shyti
Quoted 6 lines · Heikki Krogerus
There are quite a few drivers and options for the DesignWare I2C adapter in the
Kconfig. Grouping all of them under theI2C_DESIGNWARE_CORE. That makes the menuconfig a bit more easier to understand.Signed-off-by Heikki Krogerus <[email protected]>Thanks for your patch, I can take this only after the other patches have been taken in.
Quoted 8 lines
Quoted 4 lines
I assume then that you're expecting the prereqs to go through the various arch trees? Is this not trivial enough that you could chuck it on a dedicated branch in your tree and if, for some reason, there's a non-trivial conflict the affected could pull it in?
Thanks for your advice: considering that cross-domain patches are difficult to handle, I appreciate any suggestion on how to deal with them :-)
It's also helpful if the submitter of a series proposes what path patches should take upstream. I find that people all look at something like this and see "someone else's problem" written all over it, and would be perfectly happy to accept a proposal from a submitter that it all goes via I2C.
Quoted 2 lines
Are you suggesting to set these up in a different branch and send a pull request out of that branch?
What I meant was put them in a dedicated branch (so probably on top of -rc1 or similar) and merge that branch into your for-next branch. If someone then was to run into a non-trivial conflict you could tag the dedicated branch and they could pull it into their tree.
Quoted 8 lines
Quoted 2 lines
I don't want here to step into other people branches if they don't ack or express any thought.
Sure, I wouldn't either, but it far from abnormal for driver subsystem maintainer to take these sort of rename/dependency addition patches and the normal path for 3 of the 5 architectures affected here is via Arnd and I figure there's a low probability of the maintainers of those architectures having their feels hurt.
Thanks Conor! I will take it into i2c, then. In any case, Stephen will check if there will be duplicates.
Thanks,
Andi
Andi Shyti
maintainerHi Jarkko, Andy,
...
Quoted 10 lines
Heikki Krogerus (7):
ARC: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
ARM: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
arm64: defconfig: enableI2C_DESIGNWARE_COREwith
I2C_DESIGNWARE_PLATFORM
mips: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
RISC-V: configs: enableI2C_DESIGNWARE_COREwith
I2C_DESIGNWARE_PLATFORM
net: txgbe: Fix I2CKconfigdependencies
i2c: designware: Group all DesignWare drivers under a single option
I believe you know this code already, do you mind giving it an ack?
Thanks,
Andi
Jarkko Nikula
Acked-byQuoted 15 lines · Andi Shyti
Hi Jarkko, Andy,
...
Quoted 10 lines
Heikki Krogerus (7):
ARC: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
ARM: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
arm64: defconfig: enableI2C_DESIGNWARE_COREwith
I2C_DESIGNWARE_PLATFORM
mips: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
RISC-V: configs: enableI2C_DESIGNWARE_COREwith
I2C_DESIGNWARE_PLATFORM
net: txgbe: Fix I2CKconfigdependencies
i2c: designware: Group all DesignWare drivers under a single option
Quoted 3 lines
I believe you know this code already, do you mind giving it an ack?
To the patches 1-7/7 in this set:
Hi Heikki,
Quoted 10 lines
Heikki Krogerus (7):
ARC: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
ARM: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
arm64: defconfig: enableI2C_DESIGNWARE_COREwith
I2C_DESIGNWARE_PLATFORM
mips: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORM
RISC-V: configs: enableI2C_DESIGNWARE_COREwith
I2C_DESIGNWARE_PLATFORM
net: txgbe: Fix I2CKconfigdependencies
i2c: designware: Group all DesignWare drivers under a single option
Merged to i2c/i2c-host.
Thanks,
Andi
This patch was applied to riscv/linux.git (fixes) by Andi Shyti <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (fixes)
by Andi Shyti <[email protected]>:
Quoted 8 lines · On Tue, 3 Sep 2024 17:24:59 +0300 you wrote:
Hi guys,
This is a proposal for
Kconfigimprovement regarding the Synopsys DesignWare I2C adapter driver.Changes since v1:
[...]
Here is the summary with links:
- [v2,5/7] RISC-V: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
https://git.kernel.org/riscv/c/0175b1d3c6df
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Andi Shyti
maintainerHi,
Quoted 11 lines · On Tue, Oct 01, 2024 at 11:35:13AM GMT, [email protected]…
Hello:
This patch was applied to riscv/linux.git (fixes)
by Andi Shyti <[email protected]>:Quoted 5 lines · On Tue, 3 Sep 2024 17:24:59 +0300 you wrote:
Hi guys,
This is a proposal for
Kconfigimprovement regarding the Synopsys DesignWare I2C adapter driver.
Quoted 7 lines
Quoted 3 lines
Changes since v1:
[...]
Here is the summary with links:
- [v2,5/7] RISC-V: configs: enableI2C_DESIGNWARE_COREwithI2C_DESIGNWARE_PLATFORMhttps://git.kernel.org/riscv/c/0175b1d3c6df
This patch has already been taken and merged to mainline through i2c.
Andi
Quoted 6 lines
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html