Skip to contentSkip to conversation

bpf: update docs on CONFIG_FUNCTION_ERROR_INJECTION

PATCH Applied Martin Kelly 2 participants 2 messages Oct 10, 2024 BPF

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 bpf: update docs on CONFIG_FUNCTION_ERROR_INJECTION

The documentation says CONFIG_FUNCTION_ERROR_INJECTION is supported only on x86. This was presumably true at the time of writing, but it's now supported on many other architectures too. Drop this statement, since it's not correct anymore and it fits better in other documentation anyway.

---
 include/uapi/linux/bpf.h       | 4 ----
 tools/include/uapi/linux/bpf.h | 4 ----
 2 files changed, 8 deletions(-)
include/uapi/linux/bpf.h +0 -4
index 8ab4d8184b9d..df664aaeb3f4 100644
@@ -3103,10 +3103,6 @@ union bpf_attr {
  * 		with the **CONFIG_BPF_KPROBE_OVERRIDE** configuration
  * 		option, and in this case it only works on functions tagged with
  * 		**ALLOW_ERROR_INJECTION** in the kernel code.
- *
- * 		Also, the helper is only available for the architectures having
- * 		the CONFIG_FUNCTION_ERROR_INJECTION option. As of this writing,
- * 		x86 architecture is the only one to support this feature.
  * 	Return
  * 		0
  *
tools/include/uapi/linux/bpf.h +0 -4
index 7610883c8191..de9c18bfcb00 100644
@@ -3103,10 +3103,6 @@ union bpf_attr {
  * 		with the **CONFIG_BPF_KPROBE_OVERRIDE** configuration
  * 		option, and in this case it only works on functions tagged with
  * 		**ALLOW_ERROR_INJECTION** in the kernel code.
- *
- * 		Also, the helper is only available for the architectures having
- * 		the CONFIG_FUNCTION_ERROR_INJECTION option. As of this writing,
- * 		x86 architecture is the only one to support this feature.
  * 	Return
  * 		0
  *
Signature · 1 line
2.34.1
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 9 lines · On Thu, 10 Oct 2024 12:33:01 -0700 you wrote:

The documentation says CONFIG_FUNCTION_ERROR_INJECTION is supported only on x86. This was presumably true at the time of writing, but it's now supported on many other architectures too. Drop this statement, since it's not correct anymore and it fits better in other documentation anyway.

[...]

Here is the summary with links:
- [bpf-next,v2] bpf: update docs on CONFIG_FUNCTION_ERROR_INJECTION

    https://git.kernel.org/bpf/bpf-next/c/c6ca31981b54

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html