argparse: enable code to be compiled with MSVC compiler
PATCH 1/1 argparse: enable code to be compiled with MSVC compiler
The issues that were preventing argparser from getting compiled with MSVC were fixed, so now it should not be excluded from the compilation anymore.
--- lib/argparse/meson.build | 6 ------ 1 file changed, 6 deletions(-)
lib/argparse/meson.build +0 -6
@@ -1,12 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2024 HiSilicon Limited. -if is_ms_compiler - build = false - reason = 'not supported building with Visual Studio Toolset' - subdir_done() -endif - sources = files('rte_argparse.c') headers = files('rte_argparse.h')
Signature · 1 line
2.34.1
Quoted 26 lines · Andre Muezerie
The issues that were preventing argparser from getting compiled with MSVC were fixed, so now it should not be excluded from the compilation anymore.
Signed-off-by Andre Muezerie <[email protected]>--- lib/argparse/meson.build | 6 ------ 1 file changed, 6 deletions(-)lib/argparse/meson.build +0
-6@@ -1,12 +1,6 @@ # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2024 HiSilicon Limited. -if is_ms_compiler - build = false - reason = 'not supported building with Visual Studio Toolset' - subdir_done() -endif - sources = files('rte_argparse.c') headers = files('rte_argparse.h')
Thomas Monjalon
Applied13/11/2024 01:30, fengchengwen:
Quoted 8 lines · Andre Muezerie
Quoted 5 lines
The issues that were preventing argparser from getting compiled with MSVC were fixed, so now it should not be excluded from the compilation anymore.
Signed-off-by Andre Muezerie <[email protected]>Acked-by Chengwen Feng <[email protected]>
Applied, thanks.
Quoted 4 lines · Andre Muezerie
The issues that were preventing argparser from getting compiled with MSVC were fixed, so now it should not be excluded from the compilation anymore.
Just to be sure, it relates to fixes of bz 1409, right?
It's cool no new regression was introduced in the mean time. Enabling libraries the sooner is better for getting a larger MSVC support, I see no problem in taking this patch for rc3.
Quoted 2 lines
Signed-off-by Andre Muezerie <[email protected]>
Signature · 1 line
David Marchand