Skip to contentSkip to conversation

libbpf: Improve debug message when the base BTF cannot be found

PATCH Applied Ben Olson 2 participants 2 messages Nov 26, 2024 – Nov 27, 2024

Subsystems (2)
lore
Share & tools
lore

Ben Olson

author
#0 lore raw

PATCH v3 1/1 libbpf: Improve debug message when the base BTF cannot be found

When running bpftool on a kernel module installed in /lib/modules..., this error is encountered if the user does not specify --base-btf to point to a valid base BTF (e.g. usually in /sys/kernel/btf/vmlinux). However, looking at the debug output to determine the cause of the error simply says Invalid BTF string section, which does not point to the actual source of the error. This just improves that debug message to tell users what happened.

---
 tools/lib/bpf/btf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/lib/bpf/btf.c +1 -1
index 12468ae0d573..a4ae2df68b91 100644
@@ -283,7 +283,7 @@ static int btf_parse_str_sec(struct btf *btf)
 		return -EINVAL;
 	}
 	if (!btf->base_btf && start[0]) {
-		pr_debug("Invalid BTF string section\n");
+		pr_debug("Malformed BTF string section, did you forget to provide base BTF?\n");
 		return -EINVAL;
 	}
 	return 0;
Signature · 1 line
2.47.0
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Quoted 9 lines · On Tue, 26 Nov 2024 14:08:45 -0600 you wrote:

When running bpftool on a kernel module installed in /lib/modules..., this error is encountered if the user does not specify --base-btf to point to a valid base BTF (e.g. usually in /sys/kernel/btf/vmlinux). However, looking at the debug output to determine the cause of the error simply says Invalid BTF string section, which does not point to the actual source of the error. This just improves that debug message to tell users what happened.

[...]

Here is the summary with links:
- [v3] libbpf: Improve debug message when the base BTF cannot be found

    https://git.kernel.org/bpf/bpf-next/c/c8d02b547363

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html