tools: ynl-gen-c: improve support for empty nests
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 tools: ynl-gen-c: improve support for empty nests
Empty nests are the same size as a flag at the netlink level (just a 4 byte nlattr without a payload). They are sometimes useful in case we want to only communicate a presence of something but may want to add more details later. This may be the case in the upcoming io_uring ZC patches, for example.
Improve handling of nested empty structs. We already support empty structs since a lot of netlink replies are empty, but for nested ones we need minor tweaks to avoid pointless empty lines and unused variables.
---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]
--- tools/net/ynl/ynl-gen-c.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
tools/net/ynl/ynl-gen-c.py +10 -2
@@ -1765,7 +1765,14 @@ _C_KW = { f'{struct.ptr_name}dst = yarg->data;'] init_lines = [] - _multi_parse(ri, struct, init_lines, local_vars) + if struct.member_list(): + _multi_parse(ri, struct, init_lines, local_vars) + else: + # Empty nest + ri.cw.block_start() + ri.cw.p('return 0;') + ri.cw.block_end() + ri.cw.nl() def parse_rsp_msg(ri, deref=False):
@@ -2592,7 +2599,8 @@ _C_KW = { val = attr.value val += 1 cw.p(attr.enum_name + suffix) - cw.nl() + if attr_set.items(): + cw.nl() cw.p(attr_set.cnt_name + ('' if max_by_define else ',')) if not max_by_define: cw.p(f"{attr_set.max_name} = {max_value}")
Signature · 1 line
2.47.1
Quoted 7 lines · Jakub Kicinski
Empty nests are the same size as a flag at the netlink level (just a 4 byte nlattr without a payload). They are sometimes useful in case we want to only communicate a presence of something but may want to add more details later. This may be the case in the upcoming
io_uringZC patches, for example.
Quoted 6 lines
Improve handling of nested empty structs. We already support empty structs since a lot of netlink replies are empty, but for nested ones we need minor tweaks to avoid pointless empty lines and unused variables.
Signed-off-by Jakub Kicinski <[email protected]>
Looks sensible. Assuming the context is:
https://lore.kernel.org/netdev/[email protected]/T/#Z2e.:..:20250108220644.3528845-8-dw::40davidwei.uk:1Documentation:netlink:specs:netdev.yaml
Le 08/01/2025 à 21:07, Jakub Kicinski a écrit :
Quoted 7 lines
Empty nests are the same size as a flag at the netlink level (just a 4 byte nlattr without a payload). They are sometimes useful in case we want to only communicate a presence of something but may want to add more details later. This may be the case in the upcoming
io_uringZC patches, for example.
Quoted 6 lines
Improve handling of nested empty structs. We already support empty structs since a lot of netlink replies are empty, but for nested ones we need minor tweaks to avoid pointless empty lines and unused variables.
Signed-off-by Jakub Kicinski <[email protected]>
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 8 Jan 2025 12:07:58 -0800 you wrote:
Empty nests are the same size as a flag at the netlink level (just a 4 byte nlattr without a payload). They are sometimes useful in case we want to only communicate a presence of something but may want to add more details later. This may be the case in the upcoming
io_uringZC patches, for example.[...]
Here is the summary with links:
- [net-next] tools: ynl-gen-c: improve support for empty nests
https://git.kernel.org/netdev/net-next/c/93e505a300aa
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html