Skip to contentSkip to conversation

nfc: mrvl: Don't use "proxy" headers

PATCH Applied Andy Shevchenko 2 participants 2 messages Jan 16, 2025 – Jan 19, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nfc: mrvl: Don't use "proxy" headers

Update header inclusions to follow IWYU (Include What You Use) principle.

In this case replace of_gpio.h, which is subject to remove by the GPIOLIB subsystem, with the respective headers that are being used by the driver.

---
v2: added tag (Krzysztof), elaborated what's done in the commit message (Jakub)

 drivers/nfc/nfcmrvl/uart.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/nfc/nfcmrvl/uart.c +7 -2
index 956ae92f7573..2037cd6d4f4f 100644
@@ -5,11 +5,16 @@
  * Copyright (C) 2015, Marvell International Ltd.
  */
 
-#include <linux/module.h>
 #include <linux/delay.h>
-#include <linux/of_gpio.h>
+#include <linux/device.h>
+#include <linux/err.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/printk.h>
+
 #include <net/nfc/nci.h>
 #include <net/nfc/nci_core.h>
+
 #include "nfcmrvl.h"
 
 static unsigned int hci_muxed;
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
#1 lore raw
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 10 lines · On Thu, 16 Jan 2025 17:30:37 +0200 you wrote:

Update header inclusions to follow IWYU (Include What You Use) principle.

In this case replace of_gpio.h, which is subject to remove by the GPIOLIB subsystem, with the respective headers that are being used by the driver.

[...]

Here is the summary with links:
- [net-next,v2,1/1] nfc: mrvl: Don't use "proxy" headers

    https://git.kernel.org/netdev/net-next/c/a26892ee1297

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html