Skip to contentSkip to conversation

netlink: settings: Fix PHYAD printing

PATCH Applied Florian Fainelli 2 participants 2 messages Jan 17, 2025 – Jan 20, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netlink: settings: Fix PHYAD printing

The PHY address was printed in hexadecimal rather than decimal as it used to be and is expected.

Fixes bd1341cd2146 ("add json support for base command")
---
 netlink/settings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
netlink/settings.c +1 -1
index b9b3ba9ed836..300825839e4e 100644
@@ -605,7 +605,7 @@ int linkinfo_reply_cb(const struct nlmsghdr *nlhdr, void *data)
 		uint8_t val = mnl_attr_get_u8(tb[ETHTOOL_A_LINKINFO_PHYADDR]);
 
 		print_banner(nlctx);
-		print_uint(PRINT_ANY, "phyad", "\tPHYAD: %x\n", val);
+		print_uint(PRINT_ANY, "phyad", "\tPHYAD: %u\n", val);
 	}
 	if (tb[ETHTOOL_A_LINKINFO_TRANSCEIVER]) {
 		uint8_t val;
Signature · 1 line
2.34.1
#1 lore raw
This patch was applied to ethtool/ethtool.git (master) by Michal Kubecek <[email protected]>:

Hello:

This patch was applied to ethtool/ethtool.git (master) by Michal Kubecek <[email protected]>:

Quoted 8 lines · On Fri, 17 Jan 2025 14:50:19 -0800 you wrote:

The PHY address was printed in hexadecimal rather than decimal as it used to be and is expected.

Fixes bd1341cd2146 ("add json support for base command")
---
 netlink/settings.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [ethtool] netlink: settings: Fix PHYAD printing

    https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=c6ea3bc04c73

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html