Skip to contentSkip to conversation

selftests/net: packetdrill: more xfail changes (and a correction)

PATCH Applied Jakub Kicinski 3 participants 3 messages Jan 21, 2025 – Jan 23, 2025

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 selftests/net: packetdrill: more xfail changes (and a correction)

Recent change to add more cases to XFAIL has a broken regex, the matching needs a real regex not a glob pattern.

While at it add the cases Willem pointed out during review.

Fixes 3030e3d57ba8 ("selftests/net: packetdrill: make tcp buf limited timing tests benign")

---
CC: [email protected]
CC: [email protected]
CC: [email protected]
CC: [email protected]

---
 tools/testing/selftests/net/packetdrill/ksft_runner.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
tools/testing/selftests/net/packetdrill/ksft_runner.sh +3 -1
index e15c43b7359b..ef8b25a606d8 100755
@@ -39,11 +39,13 @@ if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then
 	# xfail tests that are known flaky with dbg config, not fixable.
 	# still run them for coverage (and expect 100% pass without dbg).
 	declare -ar xfail_list=(
+		"tcp_eor_no-coalesce-retrans.pkt"
 		"tcp_fast_recovery_prr-ss.*.pkt"
+		"tcp_slow_start_slow-start-after-win-update.pkt"
 		"tcp_timestamping.*.pkt"
 		"tcp_user_timeout_user-timeout-probe.pkt"
 		"tcp_zerocopy_epoll_.*.pkt"
-		"tcp_tcp_info_tcp-info-*-limited.pkt"
+		"tcp_tcp_info_tcp-info-.*-limited.pkt"
 	)
 	readonly xfail_regex="^($(printf '%s|' "${xfail_list[@]}"))$"
 	[[ "$script" =~ ${xfail_regex} ]] && failfunc=ktap_test_xfail
Signature · 1 line
2.48.1
#2 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Tue, 21 Jan 2025 06:34:23 -0800 you wrote:

Recent change to add more cases to XFAIL has a broken regex, the matching needs a real regex not a glob pattern.

While at it add the cases Willem pointed out during review.

Fixes 3030e3d57ba8 ("selftests/net: packetdrill: make tcp buf limited timing tests benign")

[...]

Here is the summary with links:
- [net-next] selftests/net: packetdrill: more xfail changes (and a correction)

    https://git.kernel.org/netdev/net/c/965adae5a33a

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html