atm: nicstar: use NULL instead of 0 for pointer
Subsystems (3)
PATCH 1/1 atm: nicstar: use NULL instead of 0 for pointer
Quoted 1 line
From
c320d2ea1ed51c88255c33a50c74fa3598ab7be6Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 10:10:11 +0900
Subject: [PATCH] atm: nicstar: use NULL instead of 0 for pointer
sparse says:
drivers/atm/nicstar.c:642:27: warning:
Using plain integer as NULL pointerdrivers/atm/nicstar.c:644:27:
warning: Using plain integer as NULL pointerdrivers/atm/nicstar.c:982:51:
warning: Using plain integer as NULL pointerdrivers/atm/nicstar.c:996:51:
warning: Using plain integer as NULL pointer
--- drivers/atm/nicstar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/atm/nicstar.c +4 -4
@@ -639,9 +639,9 @@ static int ns_init_card(int i, struct pci_dev *pcidev) card->hbnr.init =NUM_HB ; card->hbnr.max =MAX_HB ; - card->sm_handle =0x00000000 ; + card->sm_handle =NULL ; card->sm_addr =0x00000000 ; - card->lg_handle =0x00000000 ; + card->lg_handle =NULL ; card->lg_addr =0x00000000 ; card->efbie =1 ;/* To prevent push_rxbufs from enabling the interrupt */
@@ -979,7 +979,7 @@ static void push_rxbufs(ns_dev * card, struct sk_buff *skb) addr2 = card->sm_addr; handle2 = card->sm_handle; card->sm_addr =0x00000000 ; - card->sm_handle =0x00000000 ; + card->sm_handle =NULL ; }else {/* (!sm_addr) */ card->sm_addr = addr1;
@@ -993,7 +993,7 @@ static void push_rxbufs(ns_dev * card, struct sk_buff *skb) addr2 = card->lg_addr; handle2 = card->lg_handle; card->lg_addr =0x00000000 ; - card->lg_handle =0x00000000 ; + card->lg_handle =NULL ; }else {/* (!lg_addr) */ card->lg_addr = addr1;
Signature · 1 line
1.7.9.5
Quoted 47 lines · On Wed, 19 Feb 2014 14:12:46 +0900 Daeseok Youn <[email protected]> wrote:
Quoted 1 line
From
c320d2ea1ed51c88255c33a50c74fa3598ab7be6Mon Sep 17 00:00:00 2001From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 10:10:11 +0900
Subject: [PATCH] atm: nicstar: use NULL instead of 0 for pointersparse says:
drivers/atm/nicstar.c:642:27: warning:
Using plain integer as NULL pointerdrivers/atm/nicstar.c:644:27:
warning: Using plain integer as NULL pointerdrivers/atm/nicstar.c:982:51:
warning: Using plain integer as NULL pointerdrivers/atm/nicstar.c:996:51:
warning: Using plain integer as NULL pointerSigned-off-by Daeseok Youn <[email protected]>--- drivers/atm/nicstar.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/atm/nicstar.c +3
-3@@ -639,9 +639,9 @@ static int ns_init_card(int i, struct pci_dev *pcidev) card->hbnr.init =NUM_HB ; card->hbnr.max =MAX_HB ; - card->sm_handle =0x00000000 ; + card->sm_handle =NULL ; card->sm_addr =0x00000000 ; - card->lg_handle =0x00000000 ; + card->lg_handle =NULL ; card->lg_addr =0x00000000 ; card->efbie =1 ;/* To prevent push_rxbufs from enabling the interrupt */ @@ -979,7 +979,7 @@ static void push_rxbufs(ns_dev * card, struct sk_buff *skb) addr2 = card->sm_addr; handle2 = card->sm_handle; card->sm_addr =0x00000000 ; - card->sm_handle =0x00000000 ; + card->sm_handle =NULL ; }else {/* (!sm_addr) */ card->sm_addr = addr1;
drivers/atm/nicstar.c static void push_rxbufs(ns_dev * card, struct sk_buff *skb) · line 999
Quoted 8 lines
drivers/atm/nicstar.c +1
-1@@ -993,7 +993,7 @@ static void push_rxbufs(ns_dev * card, struct sk_buff *skb) addr2 = card->lg_addr; handle2 = card->lg_handle; card->lg_addr =0x00000000 ; - card->lg_handle =0x00000000 ; + card->lg_handle =NULL ; }else {/* (!lg_addr) */ card->lg_addr = addr1;
From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 14:12:46 +0900
Quoted 16 lines
From
c320d2ea1ed51c88255c33a50c74fa3598ab7be6Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Wed, 19 Feb 2014 10:10:11 +0900
Subject: [PATCH] atm: nicstar: use NULL instead of 0 for pointersparse says:
drivers/atm/nicstar.c:642:27: warning:
Using plain integer as NULL pointerdrivers/atm/nicstar.c:644:27:
warning: Using plain integer as NULL pointerdrivers/atm/nicstar.c:982:51:
warning: Using plain integer as NULL pointerdrivers/atm/nicstar.c:996:51:
warning: Using plain integer as NULL pointer
Quoted 1 line
Signed-off-by Daeseok Youn <[email protected]>
Applied.