RDMA/mana_ib: enable error cqes
cover RDMA/mana_ib: enable error cqes
From: Konstantin Taranov <[email protected]>
This patchset enables the mana_ib driver to query capabilities and enable creation of error cqes.
Konstantin Taranov (1):
RDMA/mana_ib: request error CQEs when supported
Shiraz Saleem (1):
RDMA/mana_ib: Query feature_flags bitmask from FW
drivers/infiniband/hw/mana/main.c | 6 +++++- drivers/infiniband/hw/mana/mana_ib.h | 10 ++++++++++ include/net/mana/gdma.h | 1 + 3 files changed, 16 insertions(+), 1 deletion(-)
Signature · 1 line
2.43.0
PATCH 1/2 RDMA/mana_ib: Query feature_flags bitmask from FW
From: Shiraz Saleem <[email protected]>
Extend the mana_ib_gd_query_adapter_caps function to retrieve and store the feature_flags from the firmware response.
--- drivers/infiniband/hw/mana/main.c | 3 ++- drivers/infiniband/hw/mana/mana_ib.h | 2 ++ include/net/mana/gdma.h | 1 + 3 files changed, 5 insertions(+), 1 deletion(-)
drivers/infiniband/hw/mana/main.c +2 -1
@@ -665,7 +665,7 @@ int mana_ib_gd_query_adapter_caps(struct mana_ib_dev *dev)mana_gd_init_req_hdr (&req.hdr,MANA_IB_GET_ADAPTER_CAP ,sizeof (req),sizeof (resp)); - req.hdr.resp.msg_version =GDMA_MESSAGE_V3 ; + req.hdr.resp.msg_version =GDMA_MESSAGE_V4 ; req.hdr.dev_id = dev->gdma_dev->dev_id; err = mana_gd_send_request(mdev_to_gc(dev), sizeof(req),
@@ -694,6 +694,7 @@ int mana_ib_gd_query_adapter_caps(struct mana_ib_dev *dev) caps->max_inline_data_size = resp.max_inline_data_size; caps->max_send_sge_count = resp.max_send_sge_count; caps->max_recv_sge_count = resp.max_recv_sge_count; + caps->feature_flags = resp.feature_flags;return 0 ; }
drivers/infiniband/hw/mana/mana_ib.h +2 -0
@@ -58,6 +58,7 @@ struct mana_ib_adapter_caps {u32 max_send_sge_count;u32 max_recv_sge_count;u32 max_inline_data_size; +u64 feature_flags; };struct mana_ib_queue {
@@ -230,6 +231,7 @@ struct mana_ib_query_adapter_caps_resp {u32 max_send_sge_count;u32 max_recv_sge_count;u32 max_inline_data_size; +u64 feature_flags; };/* HW Data */ struct mana_rnic_create_adapter_req {
include/net/mana/gdma.h +1 -0
@@ -152,6 +152,7 @@ struct gdma_general_req {#define GDMA_MESSAGE_V1 1#define GDMA_MESSAGE_V2 2#define GDMA_MESSAGE_V3 3 +#define GDMA_MESSAGE_V4 4struct gdma_general_resp {struct gdma_resp_hdr hdr;
Signature · 1 line
2.43.0
PATCH 2/2 RDMA/mana_ib: request error CQEs when supported
In reply to Konstantin TaranovFrom: Konstantin Taranov <[email protected]>
Request an adapter with error CQEs when it is supported.
--- drivers/infiniband/hw/mana/main.c | 3 +++ drivers/infiniband/hw/mana/mana_ib.h | 8 ++++++++ 2 files changed, 11 insertions(+)
drivers/infiniband/hw/mana/main.c +3 -0
@@ -794,6 +794,9 @@ int mana_ib_gd_create_rnic_adapter(struct mana_ib_dev *mdev) req.hdr.dev_id = gc->mana_ib.dev_id; req.notify_eq_id = mdev->fatal_err_eq->id; +if (mdev->adapter_caps.feature_flags &MANA_IB_FEATURE_CLIENT_ERROR_CQE_SUPPORT ) + req.feature_flags |=MANA_IB_FEATURE_CLIENT_ERROR_CQE_REQUEST ; + err =mana_gd_send_request (gc,sizeof (req), &req,sizeof (resp), &resp);if (err) {ibdev_err (&mdev->ib_dev,"Failed to create RNIC adapter err %d" , err);
drivers/infiniband/hw/mana/mana_ib.h +8 -0
@@ -211,6 +211,10 @@ struct mana_ib_query_adapter_caps_req {struct gdma_req_hdr hdr; };/*HW Data */ +enum mana_ib_adapter_features { +MANA_IB_FEATURE_CLIENT_ERROR_CQE_SUPPORT =BIT (4 ), +}; +struct mana_ib_query_adapter_caps_resp {struct gdma_resp_hdr hdr;u32 max_sq_id;
@@ -234,6 +238,10 @@ struct mana_ib_query_adapter_caps_resp {u64 feature_flags; };/* HW Data */ +enum mana_ib_adapter_features_request { +MANA_IB_FEATURE_CLIENT_ERROR_CQE_REQUEST =BIT (1 ), +};/*HW Data */ +struct mana_rnic_create_adapter_req {struct gdma_req_hdr hdr;u32 notify_eq_id;
Signature · 1 line
2.43.0
Leon Romanovsky
AppliedQuoted 9 lines · Konstantin Taranov
From: Konstantin Taranov <[email protected]>
This patchset enables the
mana_ibdriver to query capabilities and enable creation of error cqes.Konstantin Taranov (1):
RDMA/mana_ib: request error CQEs when supported[...]
Applied, thanks!
[1/2] RDMA/mana_ib: Query feature_flags bitmask from FW
https://git.kernel.org/rdma/rdma/c/bad4480934c822 [2/2] RDMA/mana_ib: request error CQEs when supported https://git.kernel.org/rdma/rdma/c/cd3c5ddf823016
Best regards,
Signature · 1 line
Leon Romanovsky <[email protected]>