eth: fbnic: add MAC address TCAM to debugfs
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/2 eth: fbnic: add MAC address TCAM to debugfs
From: Alexander Duyck <[email protected]>
Add read only access to the 32-entry MAC address TCAM via debugfs. BMC filtering shares the same table so this is quite useful to access during debug. See next commit for an example output.
--- .../net/ethernet/meta/fbnic/fbnic_debugfs.c | 36 +++++++++++++++++++ 1 file changed, 36 insertions(+)
drivers/net/ethernet/meta/fbnic/fbnic_debugfs.c +36 -0
@@ -10,6 +10,40 @@static struct dentry *fbnic_dbg_root; +static void fbnic_dbg_desc_break (struct seq_file *s,int i) +{ +while (i--) +seq_putc (s,'-' ); + +seq_putc (s,'\n' ); +} + +static int fbnic_dbg_mac_addr_show (struct seq_file *s,void *v) +{ +struct fbnic_dev *fbd = s->private; +char hdr[80 ]; +int i; + +/* Generate Header */ +snprintf (hdr,sizeof (hdr),"%3s %s %-17s %s\n" , +"Idx" ,"S" ,"TCAM Bitmap" ,"Addr/Mask" ); +seq_puts (s, hdr); +fbnic_dbg_desc_break (s,strnlen (hdr,sizeof (hdr))); + +for (i =0 ; i <FBNIC_RPC_TCAM_MACDA_NUM_ENTRIES ; i++) { +struct fbnic_mac_addr *mac_addr = &fbd->mac_addr[i]; + +seq_printf (s,"%02d %d %64pb %pm\n" , + i, mac_addr->state, mac_addr->act_tcam, + mac_addr->value.addr8); +seq_printf (s," %pm\n" , + mac_addr->mask.addr8); + } + +return 0 ; +} +DEFINE_SHOW_ATTRIBUTE (fbnic_dbg_mac_addr); +static int fbnic_dbg_pcie_stats_show (struct seq_file *s,void *v) {struct fbnic_dev *fbd = s->private;
@@ -48,6 +82,8 @@ void fbnic_dbg_fbd_init(struct fbnic_dev *fbd) fbd->dbg_fbd =debugfs_create_dir (name, fbnic_dbg_root);debugfs_create_file ("pcie_stats" ,0400 , fbd->dbg_fbd, fbd, &fbnic_dbg_pcie_stats_fops); +debugfs_create_file ("mac_addr" ,0400 , fbd->dbg_fbd, fbd, + &fbnic_dbg_mac_addr_fops); }void fbnic_dbg_fbd_exit (struct fbnic_dev *fbd)
Signature · 1 line
2.48.1
Jakub Kicinski
maintainerPATCH 2/2 eth: fbnic: set IFF_UNICAST_FLT to avoid enabling promiscuous mode when adding unicast addrs
From: Alexander Duyck <[email protected]>
I realized when we were adding unicast addresses we were enabling promiscous mode. I did a bit of digging and realized we had overlooked setting the driver private flag to indicate we supported unicast filtering.
Example below shows the table with 00deadbeef01 as the main NIC address, and 5 additional addresses in the 00deadbeefX0 format.
# cat $dbgfs/mac_addr
Idx S TCAM Bitmap Addr/Mask
----------------------------------
00 0 00000000,00000000 000000000000
000000000000
01 0 00000000,00000000 000000000000
000000000000
02 0 00000000,00000000 000000000000
000000000000
...
24 0 00000000,00000000 000000000000
000000000000
25 1 00100000,00000000 00deadbeef50
000000000000
26 1 00100000,00000000 00deadbeef40
000000000000
27 1 00100000,00000000 00deadbeef30
000000000000
28 1 00100000,00000000 00deadbeef20
000000000000
29 1 00100000,00000000 00deadbeef10
000000000000
30 1 00100000,00000000 00deadbeef01
000000000000
31 0 00000000,00000000 000000000000
000000000000Before rule 31 would be active. With this change it correctly sticks to just the unicast filters.
--- drivers/net/ethernet/meta/fbnic/fbnic_netdev.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/meta/fbnic/fbnic_netdev.c +2 -0
@@ -628,6 +628,8 @@ struct net_device *fbnic_netdev_alloc(struct fbnic_dev *fbd)fbnic_rss_key_fill (fbn->rss_key);fbnic_rss_init_en_mask (fbn); + netdev->priv_flags |=IFF_UNICAST_FLT ; + netdev->features |=NETIF_F_RXHASH | NETIF_F_SG |
Signature · 1 line
2.48.1
Re: [PATCH net-next 2/2] eth: fbnic: set IFF_UNICAST_FLT to avoid enabling promiscuous mode when adding unicast addrs
Quoted 36 lines · Jakub Kicinski
From: Alexander Duyck <[email protected]>
I realized when we were adding unicast addresses we were enabling promiscous mode. I did a bit of digging and realized we had overlooked setting the driver private flag to indicate we supported unicast filtering.
Example below shows the table with
00deadbeef01as the main NIC address, and 5 additional addresses in the 00deadbeefX0 format.# cat $dbgfs/mac_addr Idx S TCAM Bitmap Addr/Mask ---------------------------------- 00 0 00000000,00000000 000000000000 000000000000 01 0 00000000,00000000 000000000000 000000000000 02 0 00000000,00000000 000000000000 000000000000 ... 24 0 00000000,00000000 000000000000 000000000000 25 1 00100000,00000000 00deadbeef50 000000000000 26 1 00100000,00000000 00deadbeef40 000000000000 27 1 00100000,00000000 00deadbeef30 000000000000 28 1 00100000,00000000 00deadbeef20 000000000000 29 1 00100000,00000000 00deadbeef10 000000000000 30 1 00100000,00000000 00deadbeef01 000000000000 31 0 00000000,00000000 000000000000 000000000000
Quoted 5 lines
Before rule 31 would be active. With this change it correctly sticks to just the unicast filters.
Signed-off-by Alexander Duyck <[email protected]>Signed-off-by Jakub Kicinski <[email protected]>
Quoted 8 lines · Jakub Kicinski
From: Alexander Duyck <[email protected]>
Add read only access to the 32-entry MAC address TCAM via debugfs. BMC filtering shares the same table so this is quite useful to access during debug. See next commit for an example output.
Signed-off-by Alexander Duyck <[email protected]>Signed-off-by Jakub Kicinski <[email protected]>
This series was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:
Hello:
This series was applied to netdev/net-next.git (main) by Paolo Abeni <[email protected]>:
Quoted 10 lines · On Mon, 3 Feb 2025 17:00:37 -0800 you wrote:
From: Alexander Duyck <[email protected]>
Add read only access to the 32-entry MAC address TCAM via debugfs. BMC filtering shares the same table so this is quite useful to access during debug. See next commit for an example output.
Signed-off-by Alexander Duyck <[email protected]>Signed-off-by Jakub Kicinski <[email protected]>[...]
Here is the summary with links:
- [net-next,1/2] eth: fbnic: add MAC address TCAM to debugfs
https://git.kernel.org/netdev/net-next/c/79c0c4689bdf - [net-next,2/2] eth: fbnic: set IFF_UNICAST_FLT to avoid enabling promiscuous mode when adding unicast addrs https://git.kernel.org/netdev/net-next/c/09717c28b76c
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html