Skip to contentSkip to conversation

selftests/bpf: DENYLIST.aarch64: enable kprobe_multi tests for ARM64

PATCH Applied Alexis Lothoré (eBPF Foundation) 2 participants 2 messages Feb 19, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/bpf: DENYLIST.aarch64: enable kprobe_multi tests for ARM64

The kprobe_multi feature was disabled on ARM64 due to the lack of fprobe support.

The fprobe rewrite on function_graph has been recently merged and thus brought support for fprobes on arm64. This then enables kprobe_multi support on arm64, and so the corresponding tests can now be run on this architecture.

Remove the tests depending on kprobe_multi from DENYLIST.aarch64 to allow those to run in CI. CONFIG_FPROBE is already correctly set in tools/testing/selftests/bpf/config

---
The tests being enabled with this series have been run locally in an ARM64 qemu environment, and in Github CI.

I only did some testing to ensure that the tests depending on kprobe_multi now run correctly on arm64, it is fair to stress that all the hard work has actually been done by M. Hiramatsu ([0])

[0] https://lore.kernel.org/bpf/173518987627.391279.3307342580035322889.stgit@devnote2/

---
 tools/testing/selftests/bpf/DENYLIST.aarch64 | 9 ---------
 1 file changed, 9 deletions(-)
tools/testing/selftests/bpf/DENYLIST.aarch64 +0 -9
index 901349da680fa67896d279d184db78e964d9ae27..6d8feda27ce9de07d77d6e384666082923e3dc76 100644
@@ -1,12 +1,3 @@
-bpf_cookie/multi_kprobe_attach_api               # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
-bpf_cookie/multi_kprobe_link_api                 # kprobe_multi_link_api_subtest:FAIL:fentry_raw_skel_load unexpected error: -3
-kprobe_multi_bench_attach                        # needs CONFIG_FPROBE
-kprobe_multi_test                                # needs CONFIG_FPROBE
-module_attach                                    # prog 'kprobe_multi': failed to auto-attach: -95
 fentry_test/fentry_many_args                     # fentry_many_args:FAIL:fentry_many_args_attach unexpected error: -524
 fexit_test/fexit_many_args                       # fexit_many_args:FAIL:fexit_many_args_attach unexpected error: -524
 tracing_struct/struct_many_args                  # struct_many_args:FAIL:tracing_struct_many_args__attach unexpected error: -524
-fill_link_info/kprobe_multi_link_info            # bpf_program__attach_kprobe_multi_opts unexpected error: -95
-fill_link_info/kretprobe_multi_link_info         # bpf_program__attach_kprobe_multi_opts unexpected error: -95
-fill_link_info/kprobe_multi_invalid_ubuff        # bpf_program__attach_kprobe_multi_opts unexpected error: -95
-missed/kprobe_recursion                          # missed_kprobe_recursion__attach unexpected error: -95 (errno 95)

---
base-commit: d3417ac824b98e8773bc04b93e09c4b93c2c6cad
change-id: 20250219-enable_kprobe_multi_tests-c8d53336e5cd

Best regards,

Signature · 3 lines
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#1 lore raw
This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <[email protected]>:

Quoted 9 lines · On Wed, 19 Feb 2025 20:41:39 +0100 you wrote:

The kprobe_multi feature was disabled on ARM64 due to the lack of fprobe support.

The fprobe rewrite on function_graph has been recently merged and thus brought support for fprobes on arm64. This then enables kprobe_multi support on arm64, and so the corresponding tests can now be run on this architecture.

[...]

Here is the summary with links:
- selftests/bpf: DENYLIST.aarch64: enable kprobe_multi tests for ARM64

    https://git.kernel.org/bpf/bpf-next/c/ac13c5087299

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html