powerpc: fix altivec_unavailable_exception Oopses
PATCH 1/1 powerpc: fix altivec_unavailable_exception Oopses
altivec_unavailable_exception is called without setting r3... it looks like the r3 that actually gets passed in as struct pt_regs *regs is the undisturbed value of r3 at the time the altivec instruction was encountered. The user actually gets to choose the pt_regs printed in the Oops!
After applying the following patch to 2.6.16-rc4, I can no longer cause an Oops by executing an altivec instruction with CONFIG_ALTIVEC=n. The same change would probably also be good for arch/ppc/kernel/head.S to fix the same Oops in 2.6.15.4, though I haven't tested that.
powerpc/kernel/head_32.S renamed from powerpc/kernel/head_32.S.orig +1 -0
@@ -714,6 +714,7 @@ #ifdef CONFIG_ALTIVEC bne load_up_altivec /* if from user, just load it up */ #endif /* CONFIG_ALTIVEC */ + addi r3,r1,STACK_FRAME_OVERHEAD EXC_XFER_EE_LITE(0xf20, altivec_unavailable_exception) PerformanceMonitor:
Quoted 14 lines · Alan Curry
altivec_unavailable_exceptionis called without setting r3... it looks like the r3 that actually gets passed in as structpt_regs*regs is the undisturbed value of r3 at the time the altivec instruction was encountered. The user actually gets to choose thept_regsprinted in the Oops!After applying the following patch to 2.6.16-rc4, I can no longer cause an Oops by executing an altivec instruction with
CONFIG_ALTIVEC=n. The same change would probably also be good forarch/ppc/kernel/head.Sto fix the same Oops in 2.6.15.4, though I haven't tested that.---
arch/powerpc/kernel/head_32.S.orig2006-02-21
15:58:18.000000000 -0500
+++arch/powerpc/kernel/head_32.S2006-02-21 15:59:23.000000000 -0500
powerpc/kernel/head_32.S line 720
Quoted 7 lines
powerpc/kernel/head_32.S renamed from powerpc/kernel/head_32.S.orig +1
-0@@ -714,6 +714,7 @@ #ifdef CONFIG_ALTIVEC bne load_up_altivec /* if from user, just load it up */ #endif /* CONFIG_ALTIVEC */ + addi r3,r1,STACK_FRAME_OVERHEAD EXC_XFER_EE_LITE(0xf20, altivec_unavailable_exception) PerformanceMonitor:
Would you mine providing a patch for arch/ppc/kernel/head.S and adding a signed-off-by line.
- k
Kumar Gala writes the following:
Quoted 3 lines
Would you mine providing a patch for
arch/ppc/kernel/head.Sand adding a signed-off-by line.
OK, combined patch... applies clean to 2.6.16-rc4, applies with fuzz to 2.6.15.4, both compiled and tested. Patch prevents Oopsing of CONFIG_ALTIVEC=n kernel by user executing altivec instruction in both cases.
ppc/kernel/head.S renamed from ppc/kernel/head.S.orig +1 -0
@@ -751,6 +751,7 @@ AltiVecUnavailable: #ifdef CONFIG_ALTIVEC bne load_up_altivec /* if from user, just load it up */ #endif /* CONFIG_ALTIVEC */ + addi r3,r1,STACK_FRAME_OVERHEAD EXC_XFER_EE_LITE(0xf20, altivec_unavailable_exception) #ifdef CONFIG_PPC64BRIDGE
powerpc/kernel/head_32.S renamed from powerpc/kernel/head_32.S.orig +1 -0
@@ -714,6 +714,7 @@ AltiVecUnavailable: #ifdef CONFIG_ALTIVEC bne load_up_altivec /* if from user, just load it up */ #endif /* CONFIG_ALTIVEC */ + addi r3,r1,STACK_FRAME_OVERHEAD EXC_XFER_EE_LITE(0xf20, altivec_unavailable_exception) PerformanceMonitor:
Quoted 3 lines · Alan Curry
altivec_unavailable_exceptionis called without setting r3... it looks like the r3 that actually gets passed in as structpt_regs*regs is the undisturbed value of r3 at the time the altivec instruction was encountered.
Nice catch!
Thanks,
Paul.