Skip to contentSkip to conversation

net: Silence use after free static checker warning

PATCH Applied Dan Carpenter 3 participants 3 messages Mar 4, 2025 – Mar 5, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 net: Silence use after free static checker warning

The cpu_rmap_put() will call kfree() when the last reference is dropped.

Fortunately, this is not the the last reference so it won't free it here. Unfortunately, static checkers are not clever enough and they still warn that this could lead to a use after free on the next line. Flip these two statements around to silence the static checker false positve.

---
 net/core/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/core/dev.c +1 -1
index 9189c4a048d7..c102349e04ee 100644
@@ -7072,8 +7072,8 @@ void netif_napi_set_irq_locked(struct napi_struct *napi, int irq)
 put_rmap:
 #ifdef CONFIG_RFS_ACCEL
 	if (napi->dev->rx_cpu_rmap_auto) {
-		cpu_rmap_put(napi->dev->rx_cpu_rmap);
 		napi->dev->rx_cpu_rmap->obj[napi->napi_rmap_idx] = NULL;
+		cpu_rmap_put(napi->dev->rx_cpu_rmap);
 		napi->napi_rmap_idx = -1;
 	}
 #endif
Signature · 1 line
2.47.2
Reviewed-by on v2 1/1
#1 lore raw
Quoted 7 lines · Dan Carpenter

The cpu_rmap_put() will call kfree() when the last reference is dropped.

Fortunately, this is not the the last reference so it won't free it here. Unfortunately, static checkers are not clever enough and they still warn that this could lead to a use after free on the next line. Flip these two statements around to silence the static checker false positve.

nit: *positive.

Beside that:

Thanks.

Quoted 20 lines
---
  net/core/dev.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
net/core/dev.c +1 -1
index 9189c4a048d7..c102349e04ee 100644
@@ -7072,8 +7072,8 @@ void netif_napi_set_irq_locked(struct napi_struct *napi, int irq)
  put_rmap:
  #ifdef CONFIG_RFS_ACCEL
  	if (napi->dev->rx_cpu_rmap_auto) {
-		cpu_rmap_put(napi->dev->rx_cpu_rmap);
  		napi->dev->rx_cpu_rmap->obj[napi->napi_rmap_idx] = NULL;
+		cpu_rmap_put(napi->dev->rx_cpu_rmap);
  		napi->napi_rmap_idx = -1;
  	}
  #endif
#2 lore raw
In reply to Dan Carpenter
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Tue, 4 Mar 2025 10:01:04 +0300 you wrote:

The cpu_rmap_put() will call kfree() when the last reference is dropped.

Fortunately, this is not the the last reference so it won't free it here. Unfortunately, static checkers are not clever enough and they still warn that this could lead to a use after free on the next line. Flip these two statements around to silence the static checker false positve.

[...]

Here is the summary with links:
- [v2,net-next] net: Silence use after free static checker warning

    https://git.kernel.org/netdev/net-next/c/f252f23ab657

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html