eth: bnxt: fix out-of-range access of vnic_info array
PATCH 1/1 eth: bnxt: fix out-of-range access of vnic_info array
The bnxt_queue_{start | stop}() access vnic_info as much as allocated, which indicates bp->nr_vnics.
So, it should not reach bp->vnic_info[bp->nr_vnics].
Fixes 661958552eda ("eth: bnxt: do not use BNXT_VNIC_NTUPLE unconditionally in queue restart logic")
Signed-off-by Taehee Yoo <[email protected]>
--- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/broadcom/bnxt/bnxt.c +2 -2
@@ -15651,7 +15651,7 @@ static int bnxt_queue_start(struct net_device *dev, void *qmem, int idx) cpr = &rxr->bnapi->cp_ring; cpr->sw_stats->rx.rx_resets++; -for (i =0 ; i <= bp->nr_vnics; i++) { +for (i =0 ; i < bp->nr_vnics; i++) { vnic = &bp->vnic_info[i]; rc =bnxt_hwrm_vnic_set_rss_p5 (bp, vnic, true);
@@ -15679,7 +15679,7 @@ static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx)struct bnxt_vnic_info *vnic;int i; -for (i =0 ; i <= bp->nr_vnics; i++) { +for (i =0 ; i < bp->nr_vnics; i++) { vnic = &bp->vnic_info[i]; vnic->mru =0 ; bnxt_hwrm_vnic_update(bp, vnic,
Signature · 1 line
2.34.1
Quoted 7 lines · Taehee Yoo
The bnxt_queue_{start | stop}() access
vnic_infoas much as allocated, which indicatesbp->nr_vnics.
So, it should not reach bp->vnic_info[bp->nr_vnics].Fixes 661958552eda ("eth: bnxt: do not use BNXT_VNIC_NTUPLE unconditionally in queue restart logic")Signed-off-by Taehee Yoo <[email protected]>
Thanks.
Reviewed-by Michael Chan <[email protected]>
This patch was applied to netdev/net.git (main) by Paolo Abeni <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <[email protected]>:
Quoted 8 lines · On Sun, 16 Mar 2025 02:58:37 +0000 you wrote:
The bnxt_queue_{start | stop}() access
vnic_infoas much as allocated, which indicatesbp->nr_vnics.
So, it should not reach bp->vnic_info[bp->nr_vnics].Fixes 661958552eda ("eth: bnxt: do not use BNXT_VNIC_NTUPLE unconditionally in queue restart logic")Signed-off-by Taehee Yoo <[email protected]>[...]
Here is the summary with links:
- [net] eth: bnxt: fix out-of-range access of vnic_info array
https://git.kernel.org/netdev/net/c/919f9f497dbc
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html