Skip to contentSkip to conversation

gve: unlink old napi only if page pool exists

PATCH Applied Harshitha Ramamurthy 3 participants 3 messages Mar 17, 2025 – Mar 24, 2025

Subsystems (4)
lore
Share & tools
lore

Harshitha Ramamurthy

author maintainer
#0 lore raw

PATCH 1/1 gve: unlink old napi only if page pool exists

Commit de70981f295e ("gve: unlink old napi when stopping a queue using queue API") unlinks the old napi when stopping a queue. But this breaks QPL mode of the driver which does not use page pool. Fix this by checking that there's a page pool associated with the ring.

Fixes de70981f295e ("gve: unlink old napi when stopping a queue using queue API")
---
 drivers/net/ethernet/google/gve/gve_rx_dqo.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/ethernet/google/gve/gve_rx_dqo.c +2 -1
index 2c03c39..0fcf4c9 100644
@@ -114,7 +114,8 @@ void gve_rx_stop_ring_dqo(struct gve_priv *priv, int idx)
 	if (!gve_rx_was_added_to_block(priv, idx))
 		return;
 
-	page_pool_disable_direct_recycling(rx->dqo.page_pool);
+	if (rx->dqo.page_pool)
+		page_pool_disable_direct_recycling(rx->dqo.page_pool);
 	gve_remove_napi(priv, ntfy_idx);
 	gve_rx_remove_from_block(priv, idx);
 	gve_rx_reset_ring_dqo(priv, idx);
Signature · 1 line
2.49.0.rc1.451.g8f38331e32-goog
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Harshitha Ramamurthy

Commit de70981f295e ("gve: unlink old napi when stopping a queue using queue API") unlinks the old napi when stopping a queue. But this breaks QPL mode of the driver which does not use page pool. Fix this by checking that there's a page pool associated with the ring.

Fixes de70981f295e ("gve: unlink old napi when stopping a queue using queue API")
#2 lore raw
In reply to Harshitha Ramamurthy
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 11 lines · On Mon, 17 Mar 2025 21:41:41 +0000 you wrote:

Commit de70981f295e ("gve: unlink old napi when stopping a queue using queue API") unlinks the old napi when stopping a queue. But this breaks QPL mode of the driver which does not use page pool. Fix this by checking that there's a page pool associated with the ring.

Fixes de70981f295e ("gve: unlink old napi when stopping a queue using queue API")

[...]

Here is the summary with links:
- [net] gve: unlink old napi only if page pool exists

    https://git.kernel.org/netdev/net/c/81273eb87af8

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html