Skip to contentSkip to conversation

hwrandom / exynos / PM: Use CONFIG_PM in #ifdef

PATCH In review Rafael J. Wysocki 2 participants 2 messages Dec 3, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwrandom / exynos / PM: Use CONFIG_PM in #ifdef

From: Rafael J. Wysocki <[email protected]>

CONFIG_PM is defined as the alternative of CONFIG_PM_RUNTIME and CONFIG_PM_SLEEP, so it can be used instead of that.

Besides, after commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected) PM_RUNTIME is always set if PM is set, so using the alternative isn't even necessary.

Use CONFIG_PM instead of it in drivers/char/hw_random/exynos-rng.c.

---

Please let me know if it is OK to take this one into linux-pm.

---
 drivers/char/hw_random/exynos-rng.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/hw_random/exynos-rng.c +1 -1
Index: linux-pm/drivers/char/hw_random/exynos-rng.c
===================================================================
@@ -143,7 +143,7 @@ static int exynos_rng_remove(struct plat
 	return 0;
 }
 
-#if defined(CONFIG_PM_SLEEP) || defined(CONFIG_PM_RUNTIME)
+#ifdef CONFIG_PM
 static int exynos_rng_runtime_suspend(struct device *dev)
 {
 	struct platform_device *pdev = to_platform_device(dev);
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Rafael J. Wysocki

From: Rafael J. Wysocki <[email protected]>

CONFIG_PM is defined as the alternative of CONFIG_PM_RUNTIME and CONFIG_PM_SLEEP, so it can be used instead of that.

Quoted 7 lines

Besides, after commit b2b49ccbdd54 (PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected) PM_RUNTIME is always set if PM is set, so using the alternative isn't even necessary.

Use CONFIG_PM instead of it in drivers/char/hw_random/exynos-rng.c.

Quoted 1 line

Please let me know if it is OK to take this one into linux-pm.

Sure.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt