Skip to contentSkip to conversation

selftests: net: amt: indicate progress in the stress test

PATCH Applied Jakub Kicinski 3 participants 3 messages Apr 3, 2025 – Apr 4, 2025

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 selftests: net: amt: indicate progress in the stress test

Our CI expects output from the test at least once every 10 minutes. The AMT test when running on debug kernel is just on the edge of that time for the stress test. Improve the output:
- print the name of the test first, before starting it,
- output a dot every 10% of the way.

Output after:

  TEST: amt discovery                                                 [ OK ]
  TEST: IPv4 amt multicast forwarding                                 [ OK ]
  TEST: IPv6 amt multicast forwarding                                 [ OK ]
  TEST: IPv4 amt traffic forwarding torture               ..........  [ OK ]
  TEST: IPv6 amt traffic forwarding torture               ..........  [ OK ]

---
Since net-next is closed I'm sending this for net. We enabled DEBUG_PREEMPT in the debug flavor and the test now times out most of the time.

---
 tools/testing/selftests/net/amt.sh | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
tools/testing/selftests/net/amt.sh +14 -6
index d458b45c775b..3ef209cacb8e 100755
@@ -194,15 +194,21 @@ test_remote_ip()
 
 send_mcast_torture4()
 {
-	ip netns exec "${SOURCE}" bash -c \
-		'cat /dev/urandom | head -c 1G | nc -w 1 -u 239.0.0.1 4001'
+	for i in `seq 10`; do
+		ip netns exec "${SOURCE}" bash -c \
+		   'cat /dev/urandom | head -c 100M | nc -w 1 -u 239.0.0.1 4001'
+		echo -n "."
+	done
 }
 
 
 send_mcast_torture6()
 {
-	ip netns exec "${SOURCE}" bash -c \
-		'cat /dev/urandom | head -c 1G | nc -w 1 -u ff0e::5:6 6001'
+	for i in `seq 10`; do
+		ip netns exec "${SOURCE}" bash -c \
+		   'cat /dev/urandom | head -c 100M | nc -w 1 -u ff0e::5:6 6001'
+		echo -n "."
+	done
 }
 
 check_features()
@@ -278,10 +284,12 @@ wait $pid || err=$?
 if [ $err -eq 1 ]; then
 	ERR=1
 fi
+printf "TEST: %-50s" "IPv4 amt traffic forwarding torture"
 send_mcast_torture4
-printf "TEST: %-60s  [ OK ]\n" "IPv4 amt traffic forwarding torture"
+printf "  [ OK ]\n"
+printf "TEST: %-50s" "IPv6 amt traffic forwarding torture"
 send_mcast_torture6
-printf "TEST: %-60s  [ OK ]\n" "IPv6 amt traffic forwarding torture"
+printf "  [ OK ]\n"
 sleep 5
 if [ "${ERR}" -eq 1 ]; then
         echo "Some tests failed." >&2
Signature · 1 line
2.49.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 1 line · Jakub Kicinski

Hi Jakub,
Thanks a lot for this work!

Quoted 6 lines

Our CI expects output from the test at least once every 10 minutes. The AMT test when running on debug kernel is just on the edge of that time for the stress test. Improve the output:
- print the name of the test first, before starting it,
- output a dot every 10% of the way.

Quoted 8 lines

Output after:

  TEST: amt discovery                                                 [ OK ]
  TEST: IPv4 amt multicast forwarding                                 [ OK ]
  TEST: IPv6 amt multicast forwarding                                 [ OK ]
  TEST: IPv4 amt traffic forwarding torture               ..........  [ OK ]
  TEST: IPv6 amt traffic forwarding torture               ..........  [ OK ]

I tested it, and it works well.

TEST: amt discovery [ OK ]
TEST: IPv4 amt multicast forwarding [ OK ]
TEST: IPv6 amt multicast forwarding [ OK ]
TEST: IPv4 amt traffic forwarding torture .......... [ OK ]
TEST: IPv6 amt traffic forwarding torture .......... [ OK ]

Thanks a lot!
Taehee Yoo

Quoted 61 lines

---
Since net-next is closed I'm sending this for net. We enabled DEBUG_PREEMPT in the debug flavor and the test now times out most of the time.

---
 tools/testing/selftests/net/amt.sh | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
tools/testing/selftests/net/amt.sh +14 -7
index d458b45c775b..3ef209cacb8e 100755
@@ -194,15 +194,21 @@ test_remote_ip()
 
 send_mcast_torture4()
 {
-       ip netns exec "${SOURCE}" bash -c \
-               'cat /dev/urandom | head -c 1G | nc -w 1 -u 239.0.0.1 4001'
+       for i in `seq 10`; do
+               ip netns exec "${SOURCE}" bash -c \
+                  'cat /dev/urandom | head -c 100M | nc -w 1 -u 239.0.0.1 4001'
+               echo -n "."
+       done
 }
 
 
 send_mcast_torture6()
 {
-       ip netns exec "${SOURCE}" bash -c \
-               'cat /dev/urandom | head -c 1G | nc -w 1 -u ff0e::5:6 6001'
+       for i in `seq 10`; do
+               ip netns exec "${SOURCE}" bash -c \
+                  'cat /dev/urandom | head -c 100M | nc -w 1 -u ff0e::5:6 6001'
+               echo -n "."
+       done
 }
 
 check_features()
@@ -278,10 +284,12 @@ wait $pid || err=$?
 if [ $err -eq 1 ]; then
        ERR=1
 fi
+printf "TEST: %-50s" "IPv4 amt traffic forwarding torture"
 send_mcast_torture4
-printf "TEST: %-60s  [ OK ]\n" "IPv4 amt traffic forwarding torture"
+printf "  [ OK ]\n"
+printf "TEST: %-50s" "IPv6 amt traffic forwarding torture"
 send_mcast_torture6
-printf "TEST: %-60s  [ OK ]\n" "IPv6 amt traffic forwarding torture"
+printf "  [ OK ]\n"
 sleep 5
 if [ "${ERR}" -eq 1 ]; then
         echo "Some tests failed." >&2
--

2.49.0

#2 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Thu, 3 Apr 2025 07:56:36 -0700 you wrote:

Our CI expects output from the test at least once every 10 minutes. The AMT test when running on debug kernel is just on the edge of that time for the stress test. Improve the output:
- print the name of the test first, before starting it,
- output a dot every 10% of the way.

Output after:

[...]

Here is the summary with links:
- [net] selftests: net: amt: indicate progress in the stress test

    https://git.kernel.org/netdev/net/c/94f68c0f99a5

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html