Skip to contentSkip to conversation

platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

PATCH In review Hans de Goede 3 participants 10 messages Apr 7, 2025 – Apr 11, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both need to be handled by the x86-android-tablets code. Add 9v to the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet symbols to prepare for adding support for the 5V version.

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/

---
 .../platform/x86/x86-android-tablets/dmi.c    |  2 +-
 .../platform/x86/x86-android-tablets/other.c  | 64 +++++++++----------
 .../x86-android-tablets/x86-android-tablets.h |  2 +-
 3 files changed, 34 insertions(+), 34 deletions(-)
drivers/platform/x86/x86-android-tablets/dmi.c +1 -1
index 3e5fa3b6e2fd..e43d482b17a3 100644
@@ -187,7 +187,7 @@ const struct dmi_system_id x86_android_tablet_ids[] __initconst = {
 			/* Above strings are too generic, also match on BIOS date */
 			DMI_MATCH(DMI_BIOS_DATE, "08/25/2014"),
 		},
-		.driver_data = (void *)&vexia_edu_atla10_info,
+		.driver_data = (void *)&vexia_edu_atla10_9v_info,
 	},
 	{
 		/* Whitelabel (sold as various brands) TM800A550L */
drivers/platform/x86/x86-android-tablets/other.c +32 -32

154 lines not on this page · raw message

drivers/platform/x86/x86-android-tablets/x86-android-tablets.h +1 -1
index 63a38a0069ba..2204bbaf2ed5 100644
@@ -127,7 +127,7 @@ extern const struct x86_dev_info nextbook_ares8_info;
 extern const struct x86_dev_info nextbook_ares8a_info;
 extern const struct x86_dev_info peaq_c1010_info;
 extern const struct x86_dev_info whitelabel_tm800a550l_info;
-extern const struct x86_dev_info vexia_edu_atla10_info;
+extern const struct x86_dev_info vexia_edu_atla10_9v_info;
 extern const struct x86_dev_info xiaomi_mipad2_info;
 extern const struct dmi_system_id x86_android_tablet_ids[];
 
Signature · 1 line
2.49.0
#1 lore raw

PATCH 2/2 platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both are x86 ACPI tablets which ships with Android x86 as factory OS. with a DSDT which contains a bunch of I2C devices which are not actually there, causing various resource conflicts. Enumeration of these is skipped through the acpi_quirk_skip_i2c_client_enumeration().

Extend the existing support for the 9V version by adding support for manually instantiating the I2C devices which are actually present on the 5V version by adding the necessary device info to
the x86-android-tablets module.

---
 .../platform/x86/x86-android-tablets/dmi.c    | 12 ++++
 .../platform/x86/x86-android-tablets/other.c  | 60 +++++++++++++++++++
 .../x86-android-tablets/x86-android-tablets.h |  1 +
 3 files changed, 73 insertions(+)
drivers/platform/x86/x86-android-tablets/dmi.c +12 -0
index e43d482b17a3..278c6d151dc4 100644
@@ -179,6 +179,18 @@ const struct dmi_system_id x86_android_tablet_ids[] __initconst = {
 		},
 		.driver_data = (void *)&peaq_c1010_info,
 	},
+	{
+		/* Vexia Edu Atla 10 tablet 5V version */
+		.matches = {
+			/* Having all 3 of these not set is somewhat unique */
+			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
+			/* Above strings are too generic, also match on BIOS date */
+			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
+		},
+		.driver_data = (void *)&vexia_edu_atla10_5v_info,
+	},
 	{
 		/* Vexia Edu Atla 10 tablet 9V version */
 		.matches = {
drivers/platform/x86/x86-android-tablets/other.c +60 -0

66 lines not on this page · raw message

drivers/platform/x86/x86-android-tablets/x86-android-tablets.h +1 -0
index 2204bbaf2ed5..dcf8d49e3b5f 100644
@@ -127,6 +127,7 @@ extern const struct x86_dev_info nextbook_ares8_info;
 extern const struct x86_dev_info nextbook_ares8a_info;
 extern const struct x86_dev_info peaq_c1010_info;
 extern const struct x86_dev_info whitelabel_tm800a550l_info;
+extern const struct x86_dev_info vexia_edu_atla10_5v_info;
 extern const struct x86_dev_info vexia_edu_atla10_9v_info;
 extern const struct x86_dev_info xiaomi_mipad2_info;
 extern const struct dmi_system_id x86_android_tablet_ids[];
Signature · 1 line
2.49.0
#2 lore raw

Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

Quoted 13 lines · Hans de Goede

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both are x86 ACPI tablets which ships with Android x86 as factory OS. with a DSDT which contains a bunch of I2C devices which are not actually there, causing various resource conflicts. Enumeration of these is skipped through the acpi_quirk_skip_i2c_client_enumeration().

Extend the existing support for the 9V version by adding support for manually instantiating the I2C devices which are actually present on the 5V version by adding the necessary device info to
the x86-android-tablets module.

...

drivers/platform/x86/x86-android-tablets/dmi.c const struct dmi_system_id x86_android_tablet_ids[] __initconst = { · line 191

Quoted 10 lines
drivers/platform/x86/x86-android-tablets/dmi.c +10 -0
+	{
+		/* Vexia Edu Atla 10 tablet 5V version */
+		.matches = {
+			/* Having all 3 of these not set is somewhat unique */
+			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
+			/* Above strings are too generic, also match on BIOS date */
+			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
+		},

Oh, this is unfortunate matching and quite fragile. Do we have other matching mechanisms in place in addition to this?

I am not against this change, but perhaps we need also add something to check, say, CPUID before looking into this table or so?

Quoted 2 lines
drivers/platform/x86/x86-android-tablets/dmi.c +2 -0
+		.driver_data = (void *)&vexia_edu_atla10_5v_info,
+	},
Signature · 2 lines
With Best Regards,
Andy Shevchenko
#3 lore raw

Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

Hi,

Quoted 17 lines · Andy Shevchenko
Quoted 13 lines · Hans de Goede

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both are x86 ACPI tablets which ships with Android x86 as factory OS. with a DSDT which contains a bunch of I2C devices which are not actually there, causing various resource conflicts. Enumeration of these is skipped through the acpi_quirk_skip_i2c_client_enumeration().

Extend the existing support for the 9V version by adding support for manually instantiating the I2C devices which are actually present on the 5V version by adding the necessary device info to
the x86-android-tablets module.

...

Quoted 13 lines

drivers/platform/x86/x86-android-tablets/dmi.c const struct dmi_system_id x86_android_tablet_ids[] __initconst = { · line 191

Quoted 10 lines
drivers/platform/x86/x86-android-tablets/dmi.c +10 -0
+	{
+		/* Vexia Edu Atla 10 tablet 5V version */
+		.matches = {
+			/* Having all 3 of these not set is somewhat unique */
+			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
+			/* Above strings are too generic, also match on BIOS date */
+			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
+		},

Oh, this is unfortunate matching and quite fragile. Do we have other matching mechanisms in place in addition to this?

Having both PRODUCT_NAME and BOARD_NAME set to "To be filled by O.E.M." is actually pretty rare. Of all the DMI decode's which I've collected only 2 other devices have this. Usually at least on of the 2 is set to something less generic even if that something is still sometimes not super useful itself like "BayTrail".

So IMHO combined with the BIOS date this should be plenty unique IMHO.

Regards,

Hans

#4 lore raw

Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data

Quoted 2 lines · Hans de Goede
Quoted 1 line · Andy Shevchenko

On Mon, Apr 07, 2025 at 11:20:16AM +0200, Hans de Goede wrote:

...

Quoted 14 lines
Quoted 5 lines
Quoted 5 lines
drivers/platform/x86/x86-android-tablets/dmi.c +5 -0
+	{
+		/* Vexia Edu Atla 10 tablet 5V version */
+		.matches = {
+			/* Having all 3 of these not set is somewhat unique */
+			DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
Quoted 8 lines

drivers/platform/x86/x86-android-tablets/dmi.c const struct dmi_system_id x86_android_tablet_ids[] __initconst = { · line 191

Quoted 5 lines
drivers/platform/x86/x86-android-tablets/dmi.c +5 -0
+			DMI_MATCH(DMI_PRODUCT_NAME, "To be filled by O.E.M."),
+			DMI_MATCH(DMI_BOARD_NAME, "To be filled by O.E.M."),
+			/* Above strings are too generic, also match on BIOS date */
+			DMI_MATCH(DMI_BIOS_DATE, "05/14/2015"),
+		},

Oh, this is unfortunate matching and quite fragile. Do we have other matching mechanisms in place in addition to this?

Quoted 7 lines

Having both PRODUCT_NAME and BOARD_NAME set to "To be filled by O.E.M." is actually pretty rare. Of all the DMI decode's which I've collected only 2 other devices have this. Usually at least on of the 2 is set to something less generic even if that something is still sometimes not super useful itself like "BayTrail".

So IMHO combined with the BIOS date this should be plenty unique IMHO.

Sounds like a relief to me. Thanks for digging into this!

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw
In reply to Hans de Goede
Quoted 9 lines · Hans de Goede

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both need to be handled by the x86-android-tablets code. Add 9v to the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet symbols to prepare for adding support for the 5V version.

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/

And period :-)

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#6 lore raw

Hi,

Quoted 9 lines · Andy Shevchenko
Quoted 8 lines · Hans de Goede

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both need to be handled by the x86-android-tablets code. Add 9v to the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet symbols to prepare for adding support for the 5V version.

Quoted 5 lines
Quoted 1 line

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/

And period :-)

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.

It feels a bit silly to send a v2 just to add a period to the commit msg.

Ilpo do you want me to send a v2 of this series?

Regards,

Hans

#7 lore raw
Quoted 10 lines · Hans de Goede
Quoted 9 lines · Andy Shevchenko
Quoted 8 lines · Hans de Goede

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both need to be handled by the x86-android-tablets code. Add 9v to the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet symbols to prepare for adding support for the 5V version.

Quoted 7 lines
Quoted 5 lines
Quoted 1 line

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/

And period :-)

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.

It feels a bit silly to send a v2 just to add a period to the commit msg.

I agree, it can be tweaked whilst applying, but I'm not the one in charge here :-)

Quoted 1 line

Ilpo do you want me to send a v2 of this series?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
maintainer
#8 lore raw
In reply to Hans de Goede
Quoted 12 lines · Hans de Goede
Quoted 11 lines · Andy Shevchenko
Quoted 9 lines · Hans de Goede

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both need to be handled by the x86-android-tablets code. Add 9v to the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet symbols to prepare for adding support for the 5V version.

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/

Quoted 7 lines
Quoted 3 lines

And period :-)

All this patch does is s/vexia_edu_atla10_info/vexia_edu_atla10_9v_info/.

It feels a bit silly to send a v2 just to add a period to the commit msg.

Ilpo do you want me to send a v2 of this series?

No, you don't have to send a new version because of that. I'll try to remember to add the period there while applying but I won't have regrets if I fail to remember it, TBH. :-)

Signature · 1 line
 i.
maintainer
#9 lore raw
In reply to Hans de Goede
Quoted 9 lines · Hans de Goede

The Vexia EDU ATLA 10 tablet comes in 2 different versions with significantly different mainboards. The only outward difference is that the charging barrel on one is marked 5V and the other is marked 9V.

Both need to be handled by the x86-android-tablets code. Add 9v to the symbols for the existing support for the 9V Vexia EDU ATLA 10 tablet symbols to prepare for adding support for the 5V version.

[...]

Thank you for your contribution, it has been applied to my local review-ilpo-fixes branch. Note it will show up in the public platform-drivers-x86/review-ilpo-fixes branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/2] platform/x86: x86-android-tablets: Add "9v" to Vexia EDU ATLA 10 tablet symbols

      commit: 3343b086c7035222c24956780ea4423655cad6d2
[2/2] platform/x86: x86-android-tablets: Add Vexia Edu Atla 10 tablet 5V data
      commit: 59df54c67be3e587e4217bddd793350fbe8f5feb

--
i.