netlink: specs: ovs_vport: align with C codegen capabilities
Subsystems (3)
Jakub Kicinski
maintainerPATCH 1/1 netlink: specs: ovs_vport: align with C codegen capabilities
We started generating C code for OvS a while back, but actually C codegen only supports fixed headers specified at the family level right now (schema also allows specifying them per op). ovs_flow and ovs_datapath already specify the fixed header at the family level but ovs_vport does it per op. Move the property, all ops use the same header.
This ensures YNL C sees the correct hdr_len:
const struct ynl_family ynl_ovs_vport_family = {
.name = "ovs_vport", - .hdr_len = sizeof(struct genlmsghdr), + .hdr_len = sizeof(struct genlmsghdr) + sizeof(struct ovs_header),
};
---
CC: [email protected]
CC: [email protected]
--- Documentation/netlink/specs/ovs_vport.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
Documentation/netlink/specs/ovs_vport.yaml +1 -3
@@ -123,12 +123,12 @@ uapi-header: linux/openvswitch.h operations: name-prefix: ovs-vport-cmd- + fixed-header: ovs-header list: - name: new doc: Create a new OVS vport attribute-set: vport - fixed-header: ovs-header do: request: attributes:
@@ -141,7 +141,6 @@ uapi-header: linux/openvswitch.h name: del doc: Delete existing OVS vport from a data path attribute-set: vport - fixed-header: ovs-header do: request: attributes:
@@ -152,7 +151,6 @@ uapi-header: linux/openvswitch.h name: get doc: Get / dump OVS vport configuration and state attribute-set: vport - fixed-header: ovs-header do: &vport-get-op request: attributes:
Signature · 1 line
2.49.0
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 9 Apr 2025 07:55:41 -0700 you wrote:
We started generating C code for OvS a while back, but actually C codegen only supports fixed headers specified at the family level right now (schema also allows specifying them per op).
ovs_flowandovs_datapathalready specify the fixed header at the family level butovs_vportdoes it per op. Move the property, all ops use the same header.[...]
Here is the summary with links:
- [net] netlink: specs: ovs_vport: align with C codegen capabilities
https://git.kernel.org/netdev/net/c/747fb8413aaa
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html