net: ethernet: ti: am65-cpsw: fix port_np reference counting
Subsystems (2)
PATCH 1/1 net: ethernet: ti: am65-cpsw: fix port_np reference counting
A reference to the device tree node is stored in a private struct, thus the reference count has to be incremented. Also, decrement the count on device removal and in the error path.
--- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)
drivers/net/ethernet/ti/am65-cpsw-nuss.c +14 -1
@@ -2666,7 +2666,7 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)of_property_read_bool (port_np,"ti,mac-only" );/* get phy/link info */ - port->slave.port_np = port_np; + port->slave.port_np =of_node_get (port_np); ret =of_get_phy_mode (port_np, &port->slave.phy_if);if (ret) { dev_err(dev, "%pOF read phy-mode err %d\n",
@@ -2720,6 +2720,17 @@ static void am65_cpsw_nuss_phylink_cleanup(struct am65_cpsw_common *common) } } +static void am65_cpsw_remove_dt (struct am65_cpsw_common *common) +{ +struct am65_cpsw_port *port; +int i; + +for (i =0 ; i < common->port_num; i++) { + port = &common->ports[i]; +of_node_put (port->slave.port_np); + } +} +static int am65_cpsw_nuss_init_port_ndev (struct am65_cpsw_common *common,u32 port_idx) {
@@ -3622,6 +3633,7 @@ static int am65_cpsw_nuss_probe(struct platform_device *pdev)am65_cpsw_nuss_cleanup_ndev (common);am65_cpsw_nuss_phylink_cleanup (common);am65_cpts_release (common->cpts); +am65_cpsw_remove_dt (common); err_of_clear:if (common->mdio_dev)of_platform_device_destroy (common->mdio_dev,NULL );
@@ -3661,6 +3673,7 @@ static void am65_cpsw_nuss_remove(struct platform_device *pdev)am65_cpsw_nuss_phylink_cleanup (common);am65_cpts_release (common->cpts);am65_cpsw_disable_serdes_phy (common); +am65_cpsw_remove_dt (common);if (common->mdio_dev)of_platform_device_destroy (common->mdio_dev,NULL );
Signature · 1 line
2.39.5
Quoted 6 lines · Michael Walle
A reference to the device tree node is stored in a private struct, thus the reference count has to be incremented. Also, decrement the count on device removal and in the error path.
Fixes 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")Signed-off-by Michael Walle <[email protected]>
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Mon, 14 Apr 2025 10:39:42 +0200 you wrote:
A reference to the device tree node is stored in a private struct, thus the reference count has to be incremented. Also, decrement the count on device removal and in the error path.
Fixes 93a76530316a ("net: ethernet: ti: introduce am65x/j721e gigabit eth subsystem driver")Signed-off-by Michael Walle <[email protected]>[...]
Here is the summary with links:
- [net] net: ethernet: ti: am65-cpsw: fix port_np reference counting
https://git.kernel.org/netdev/net/c/903d2b9f9efc
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html