riscv: Fix unaligned access info messages
PATCH 1/1 riscv: Fix unaligned access info messages
Ensure we only print messages about command line parameters when the parameters are actually in use. Also complain about the use of the vector parameter when vector support isn't available.
--- arch/riscv/kernel/unaligned_access_speed.c | 35 +++++++++++++--------- 1 file changed, 21 insertions(+), 14 deletions(-)
arch/riscv/kernel/unaligned_access_speed.c +21 -14
@@ -439,29 +439,36 @@ static int __init check_unaligned_access_all_cpus(void) {int cpu; -if (unaligned_scalar_speed_param ==RISCV_HWPROBE_MISALIGNED_SCALAR_UNKNOWN && - !check_unaligned_access_emulated_all_cpus ()) { -check_unaligned_access_speed_all_cpus (); - }else { -pr_info ("scalar unaligned access speed set to '%s' by command line\n" , - speed_str[unaligned_scalar_speed_param]); +if (unaligned_scalar_speed_param !=RISCV_HWPROBE_MISALIGNED_SCALAR_UNKNOWN ) { +pr_info ("scalar unaligned access speed set to '%s' (%lu) by command line\n" , + speed_str[unaligned_scalar_speed_param], unaligned_scalar_speed_param);for_each_online_cpu (cpu)per_cpu (misaligned_access_speed, cpu) = unaligned_scalar_speed_param; + }else if (!check_unaligned_access_emulated_all_cpus ()) { +check_unaligned_access_speed_all_cpus (); + } + +if (unaligned_vector_speed_param !=RISCV_HWPROBE_MISALIGNED_VECTOR_UNKNOWN ) { +if (!has_vector () && + unaligned_vector_speed_param !=RISCV_HWPROBE_MISALIGNED_VECTOR_UNSUPPORTED ) { +pr_warn ("vector support is not available, ignoring unaligned_vector_speed=%s\n" , + speed_str[unaligned_vector_speed_param]); + }else { +pr_info ("vector unaligned access speed set to '%s' (%lu) by command line\n" , + speed_str[unaligned_vector_speed_param], unaligned_vector_speed_param); + } }if (!has_vector ()) unaligned_vector_speed_param =RISCV_HWPROBE_MISALIGNED_VECTOR_UNSUPPORTED ; -if (unaligned_vector_speed_param ==RISCV_HWPROBE_MISALIGNED_VECTOR_UNKNOWN && - !check_vector_unaligned_access_emulated_all_cpus () && -IS_ENABLED (CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS )) { -kthread_run (vec_check_unaligned_access_speed_all_cpus, -NULL ,"vec_check_unaligned_access_speed_all_cpus" ); - }else { -pr_info ("vector unaligned access speed set to '%s' by command line\n" , - speed_str[unaligned_vector_speed_param]); +if (unaligned_vector_speed_param !=RISCV_HWPROBE_MISALIGNED_VECTOR_UNKNOWN ) {for_each_online_cpu (cpu)per_cpu (vector_misaligned_access, cpu) = unaligned_vector_speed_param; + }else if (!check_vector_unaligned_access_emulated_all_cpus () && +IS_ENABLED (CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS )) { +kthread_run (vec_check_unaligned_access_speed_all_cpus, +NULL ,"vec_check_unaligned_access_speed_all_cpus" ); }/*
Signature · 1 line
2.48.1
Hi Drew,
Quoted 58 lines · Andrew Jones
Ensure we only print messages about command line parameters when the parameters are actually in use. Also complain about the use of the vector parameter when vector support isn't available.
Fixes aecb09e091dc ("riscv: Add parameter for skipping access speed tests")Reported-by Geert Uytterhoeven <[email protected]>Closes https://lore.kernel.org/all/CAMuHMdVEp2_ho51gkpLLJG2HimqZ1gZ0fa=JA4uNNZjFFqaPMg@mail.gmail.com/ open hereCloses https://lore.kernel.org/all/CAMuHMdWVMP0MYCLFq+b7H_uz-2omdFiDDUZq0t_gw0L9rrJtkQ@mail.gmail.com/ open hereSigned-off-by Andrew Jones <[email protected]>--- arch/riscv/kernel/unaligned_access_speed.c | 35 +++++++++++++--------- 1 file changed, 21 insertions(+), 14 deletions(-)arch/riscv/kernel/unaligned_access_speed.c +16
-14@@ -439,29 +439,36 @@ static int __init check_unaligned_access_all_cpus(void) {int cpu; -if (unaligned_scalar_speed_param ==RISCV_HWPROBE_MISALIGNED_SCALAR_UNKNOWN && - !check_unaligned_access_emulated_all_cpus ()) { -check_unaligned_access_speed_all_cpus (); - }else { -pr_info ("scalar unaligned access speed set to '%s' by command line\n" , - speed_str[unaligned_scalar_speed_param]); +if (unaligned_scalar_speed_param !=RISCV_HWPROBE_MISALIGNED_SCALAR_UNKNOWN ) { +pr_info ("scalar unaligned access speed set to '%s' (%lu) by command line\n" , + speed_str[unaligned_scalar_speed_param], unaligned_scalar_speed_param);for_each_online_cpu (cpu)per_cpu (misaligned_access_speed, cpu) = unaligned_scalar_speed_param; + }else if (!check_unaligned_access_emulated_all_cpus ()) { +check_unaligned_access_speed_all_cpus (); + } + +if (unaligned_vector_speed_param !=RISCV_HWPROBE_MISALIGNED_VECTOR_UNKNOWN ) { +if (!has_vector () && + unaligned_vector_speed_param !=RISCV_HWPROBE_MISALIGNED_VECTOR_UNSUPPORTED ) { +pr_warn ("vector support is not available, ignoring unaligned_vector_speed=%s\n" , + speed_str[unaligned_vector_speed_param]); + }else { +pr_info ("vector unaligned access speed set to '%s' (%lu) by command line\n" , + speed_str[unaligned_vector_speed_param], unaligned_vector_speed_param); + } }if (!has_vector ()) unaligned_vector_speed_param =RISCV_HWPROBE_MISALIGNED_VECTOR_UNSUPPORTED ; -if (unaligned_vector_speed_param ==RISCV_HWPROBE_MISALIGNED_VECTOR_UNKNOWN && - !check_vector_unaligned_access_emulated_all_cpus () && -IS_ENABLED (CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS )) { -kthread_run (vec_check_unaligned_access_speed_all_cpus, -NULL ,"vec_check_unaligned_access_speed_all_cpus" ); - }else { -pr_info ("vector unaligned access speed set to '%s' by command line\n" , - speed_str[unaligned_vector_speed_param]);
arch/riscv/kernel/unaligned_access_speed.c static int __init check_unaligned_access_all_cpus(void) · line 474
Quoted 10 lines
arch/riscv/kernel/unaligned_access_speed.c +5
-0+if (unaligned_vector_speed_param !=RISCV_HWPROBE_MISALIGNED_VECTOR_UNKNOWN ) {for_each_online_cpu (cpu)per_cpu (vector_misaligned_access, cpu) = unaligned_vector_speed_param; + }else if (!check_vector_unaligned_access_emulated_all_cpus () && +IS_ENABLED (CONFIG_RISCV_PROBE_VECTOR_UNALIGNED_ACCESS )) { +kthread_run (vec_check_unaligned_access_speed_all_cpus, +NULL ,"vec_check_unaligned_access_speed_all_cpus" ); }/*
I'll wait for Geert feedback before picking it.
Thanks,
alex
Hi Andrew,
Quoted 9 lines · Andrew Jones
Ensure we only print messages about command line parameters when the parameters are actually in use. Also complain about the use of the vector parameter when vector support isn't available.
Fixes aecb09e091dc ("riscv: Add parameter for skipping access speed tests")Reported-by Geert Uytterhoeven <[email protected]>Closes https://lore.kernel.org/all/CAMuHMdVEp2_ho51gkpLLJG2HimqZ1gZ0fa=JA4uNNZjFFqaPMg@mail.gmail.com/ open hereCloses https://lore.kernel.org/all/CAMuHMdWVMP0MYCLFq+b7H_uz-2omdFiDDUZq0t_gw0L9rrJtkQ@mail.gmail.com/ open hereSigned-off-by Andrew Jones <[email protected]>
Thanks, this gets rid of the bogus messages!
Impact on SiPEED MAiX BiT:
-scalar unaligned access speed set to '(null)' by command line -vector unaligned access speed set to 'unsupported' by command line
BeagleV Beta Starlight:
-vector unaligned access speed set to 'unsupported' by command line
Renesas RZ/Five:
-vector unaligned access speed set to 'unsupported' by command line
MPFS Icicle:
-vector unaligned access speed set to 'unsupported' by command line
Gr{oetje,eeting}s,
Geert
Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
This patch was applied to riscv/linux.git (fixes) by Alexandre Ghiti <[email protected]>:
Hello:
This patch was applied to riscv/linux.git (fixes)
by Alexandre Ghiti <[email protected]>:
Quoted 11 lines · On Wed, 9 Apr 2025 17:36:51 +0200 you wrote:
Ensure we only print messages about command line parameters when the parameters are actually in use. Also complain about the use of the vector parameter when vector support isn't available.
Fixes aecb09e091dc ("riscv: Add parameter for skipping access speed tests")Reported-by Geert Uytterhoeven <[email protected]>Closes https://lore.kernel.org/all/CAMuHMdVEp2_ho51gkpLLJG2HimqZ1gZ0fa=JA4uNNZjFFqaPMg@mail.gmail.com/ open hereCloses https://lore.kernel.org/all/CAMuHMdWVMP0MYCLFq+b7H_uz-2omdFiDDUZq0t_gw0L9rrJtkQ@mail.gmail.com/ open hereSigned-off-by Andrew Jones <[email protected]>[...]
Here is the summary with links:
- riscv: Fix unaligned access info messages
https://git.kernel.org/riscv/c/441016056010
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html