net: b53: enable BPDU reception for management port
Jonas Gorski
maintainerPATCH 1/1 net: b53: enable BPDU reception for management port
For STP to work, receiving BPDUs is essential, but the appropriate bit was never set. Without GC_RX_BPDU_EN, the switch chip will filter all BPDUs, even if an appropriate PVID VLAN was setup.
--- drivers/net/dsa/b53/b53_common.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/net/dsa/b53/b53_common.c +10 -0
@@ -737,6 +737,15 @@ static void b53_enable_mib(struct b53_device *dev)b53_write8 (dev,B53_MGMT_PAGE ,B53_GLOBAL_CONFIG , gc); } +static void b53_enable_stp (struct b53_device *dev) +{ +u8 gc; + +b53_read8 (dev,B53_MGMT_PAGE ,B53_GLOBAL_CONFIG , &gc); + gc |=GC_RX_BPDU_EN ; +b53_write8 (dev,B53_MGMT_PAGE ,B53_GLOBAL_CONFIG , gc); +} +static u16 b53_default_pvid (struct b53_device *dev) {if (is5325 (dev) ||is5365 (dev))
@@ -876,6 +885,7 @@ static int b53_switch_reset(struct b53_device *dev) }b53_enable_mib (dev); +b53_enable_stp (dev);return b53_flush_arl (dev,FAST_AGE_STATIC ); }
Signature · 1 line
2.43.0
Quoted 6 lines · Jonas Gorski
For STP to work, receiving BPDUs is essential, but the appropriate bit was never set. Without
GC_RX_BPDU_EN, the switch chip will filter all BPDUs, even if an appropriate PVID VLAN was setup.Fixes ff39c2d68679 ("net: dsa: b53: Add bridge support")Signed-off-by Jonas Gorski <[email protected]>
Thanks Jonas!
Signature · 1 line
Florian
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Mon, 14 Apr 2025 22:04:34 +0200 you wrote:
For STP to work, receiving BPDUs is essential, but the appropriate bit was never set. Without
GC_RX_BPDU_EN, the switch chip will filter all BPDUs, even if an appropriate PVID VLAN was setup.Fixes ff39c2d68679 ("net: dsa: b53: Add bridge support")Signed-off-by Jonas Gorski <[email protected]>[...]
Here is the summary with links:
- [net] net: b53: enable BPDU reception for management port
https://git.kernel.org/netdev/net/c/36355ddfe895
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html