Bluetooth: MGMT: Fix MGMT_OP_ADD_DEVICE invalid device flags
Subsystems (2)
Luiz Augusto von Dentz
maintainerPATCH 1/1 Bluetooth: MGMT: Fix MGMT_OP_ADD_DEVICE invalid device flags
From: Luiz Augusto von Dentz <[email protected]>
Device flags could be updated in the meantime while MGMT_OP_ADD_DEVICE is pending on hci_update_passive_scan_sync so instead of setting the current_flags as cmd->user_data just do a lookup using hci_conn_params_lookup and use the latest stored flags.
--- net/bluetooth/mgmt.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
net/bluetooth/mgmt.c +6 -3
@@ -7506,11 +7506,16 @@ static void add_device_complete(struct hci_dev *hdev, void *data, int err)struct mgmt_cp_add_device *cp = cmd->param;if (!err) { +struct hci_conn_params *params; + + params =hci_conn_params_lookup (hdev, &cp->addr.bdaddr, +le_addr_type (cp->addr.type)); +device_added (cmd->sk, hdev, &cp->addr.bdaddr, cp->addr.type, cp->action);device_flags_changed (NULL , hdev, &cp->addr.bdaddr, cp->addr.type, hdev->conn_flags, -PTR_UINT (cmd->user_data)); + params ? params->flags :0 ); } mgmt_cmd_complete(cmd->sk, hdev->id, MGMT_OP_ADD_DEVICE,
@@ -7613,8 +7618,6 @@ static int add_device(struct sock *sk, struct hci_dev *hdev, goto unlock; } - cmd->user_data =UINT_PTR (current_flags); - err =hci_cmd_sync_queue (hdev, add_device_sync, cmd, add_device_complete);if (err <0 ) {
Signature · 1 line
2.49.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=958246
---Test result---
Test Summary:
CheckPatch PENDING 0.36 seconds GitLint PENDING 0.23 seconds SubjectPrefix PASS 0.09 seconds BuildKernel PASS 26.35 seconds CheckAllWarning PASS 26.97 seconds CheckSparse PASS 30.79 seconds BuildKernel32 PASS 26.27 seconds TestRunnerSetup PASS 459.69 seconds TestRunner_l2cap-tester PASS 22.63 seconds TestRunner_iso-tester PASS 29.57 seconds TestRunner_bnep-tester PASS 4.80 seconds TestRunner_mgmt-tester PASS 120.68 seconds TestRunner_rfcomm-tester PASS 7.87 seconds TestRunner_sco-tester PASS 13.15 seconds TestRunner_ioctl-tester PASS 8.41 seconds TestRunner_mesh-tester PASS 6.14 seconds TestRunner_smp-tester PASS 7.19 seconds TestRunner_userchan-tester PASS 5.03 seconds IncrementalBuild PENDING 0.96 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <[email protected]>:
Quoted 8 lines · On Tue, 29 Apr 2025 15:13:19 -0400 you wrote:
From: Luiz Augusto von Dentz <[email protected]>
Device flags could be updated in the meantime while
MGMT_OP_ADD_DEVICEis pending onhci_update_passive_scan_syncso instead of setting thecurrent_flagsascmd->user_datajust do a lookup usinghci_conn_params_lookupand use the latest stored flags.[...]
Here is the summary with links:
- [v1] Bluetooth: MGMT: Fix MGMT_OP_ADD_DEVICE invalid device flags
https://git.kernel.org/bluetooth/bluetooth-next/c/a1afd438e713
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html