net: phy: Refactor fwnode_get_phy_node()
Subsystems (3)
PATCH 1/1 net: phy: Refactor fwnode_get_phy_node()
Refactor to check if the fwnode we got is correct and return if so, otherwise do additional checks. Using same pattern in all conditionals makes it slightly easier to read and understand.
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/net/phy/phy_device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/net/phy/phy_device.c +4 -4
@@ -3265,12 +3265,12 @@ struct fwnode_handle *fwnode_get_phy_node(const struct fwnode_handle *fwnode)/* Only phy-handle is used for ACPI */ phy_node =fwnode_find_reference (fwnode,"phy-handle" ,0 ); -if (is_acpi_node (fwnode) || !IS_ERR (phy_node)) +if (!IS_ERR (phy_node) ||is_acpi_node (fwnode))return phy_node; phy_node =fwnode_find_reference (fwnode,"phy" ,0 ); -if (IS_ERR (phy_node)) - phy_node =fwnode_find_reference (fwnode,"phy-device" ,0 ); -return phy_node; +if (!IS_ERR (phy_node)) +return phy_node; +return fwnode_find_reference (fwnode,"phy-device" ,0 ); }EXPORT_SYMBOL_GPL (fwnode_get_phy_node);
Signature · 1 line
2.47.2
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Wed, 30 Apr 2025 17:38:02 +0300 you wrote:
Refactor to check if the fwnode we got is correct and return if so, otherwise do additional checks. Using same pattern in all conditionals makes it slightly easier to read and understand.
Signed-off-by Andy Shevchenko <[email protected]>--- drivers/net/phy/phy_device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net-next,v1,1/1] net: phy: Refactor fwnode_get_phy_node()
https://git.kernel.org/netdev/net-next/c/1f586017f517
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html