iommu/arm-smmu-v3: Fix incorrect return in arm_smmu_attach_dev
Subsystems (2)
PATCH 1/1 iommu/arm-smmu-v3: Fix incorrect return in arm_smmu_attach_dev
An error is introduced in commit '48e7b8e284e5'. When the smmu does not match with domain,an error code is not returned.
An example of an error scenario: In vfio_iommu_type1_attach_group, vfio will try to match an existing compatible domain. During this process, iommu invokes the attach_dev interface.The mismatched dev and domain does not return an error code as expected.
As a result, an exception occurs when the vfio operates the smmu.
--- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c +1 -1
@@ -2932,7 +2932,7 @@ static int arm_smmu_attach_dev(struct iommu_domain *domain, struct device *dev) smmu = master->smmu;if (smmu_domain->smmu != smmu) -return ret; +return -EINVAL ;if (smmu_domain->stage ==ARM_SMMU_DOMAIN_S1 ) { cdptr =arm_smmu_alloc_cd_ptr (master,IOMMU_NO_PASID );
Signature · 1 line
2.33.0
Quoted 9 lines · Qinxin Xia
An error is introduced in commit '
48e7b8e284e5'. When the smmu does not match with domain,an error code is not returned.
An example of an error scenario: Invfio_iommu_type1_attach_group, vfio will try to match an existing compatible domain. During this process, iommu invokes theattach_devinterface.The mismatched dev and domain does not return an error code as expected.
As a result, an exception occurs when the vfio operates the smmu.[...]
Applied to iommu (arm/smmu/updates), thanks!
[1/1] iommu/arm-smmu-v3: Fix incorrect return in arm_smmu_attach_dev
https://git.kernel.org/iommu/c/be5a2d3f8f97
Cheers,
Signature · 5 lines
Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev