Skip to contentSkip to conversation

Propagate disconnection reason

PATCH In review Frédéric Danis 3 participants 7 messages May 23, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

v4 cover Propagate disconnection reason

Currently a client application is informed of the disconnection by the update of the Connected property to false.
This sends a Disconnected signal with the disconnection reason before the property is updated.

This will help client application to know the reason for the disconnection and to take appropriate action.

bluetoothctl is updated to display the disconnection reason on reception of the signal.

This can be tested in bluetoothctl by disconnecting a device, which generates:
[SIGNAL] org.bluez.Device1.Disconnected disconnection-local-host

v1->v2: Propagate numerical reason instead of text one
Improve documentation
Display disconnect reason in numerical and text in bluetoothctl
v2->v3: Replace numerical value by name and message to be more consistent
with Device.Connect error reply.
v3->v4: Add MGMT_DEV_DISCONN_AUTH_FAILURE to be in sync with kernel
definitions

Frédéric Danis (4):
lib/mgmt: Add MGMT_DEV_DISCONN_AUTH_FAILURE define src/device: Add Disconnected signal to propagate disconnection reason doc/device: Add Disconnected signal
client: Display disconnection reason

 client/main.c            | 18 +++++++++++++
 doc/org.bluez.Device.rst | 41 +++++++++++++++++++++++++++++
 lib/mgmt.h               |  1 +
 src/adapter.c            | 13 +++++----
 src/device.c             | 57 ++++++++++++++++++++++++++++++++++++++--
 src/device.h             |  3 ++-
 6 files changed, 125 insertions(+), 8 deletions(-)
Signature · 1 line
2.43.0
#1 lore raw

PATCH v4 1/4 lib/mgmt: Add MGMT_DEV_DISCONN_AUTH_FAILURE define

---
 lib/mgmt.h | 1 +
 1 file changed, 1 insertion(+)
lib/mgmt.h +1 -0
index 6af82fc4a..2b45010d1 100644
@@ -870,6 +870,7 @@ struct mgmt_ev_device_connected {
 #define MGMT_DEV_DISCONN_TIMEOUT	0x01
 #define MGMT_DEV_DISCONN_LOCAL_HOST	0x02
 #define MGMT_DEV_DISCONN_REMOTE		0x03
+#define MGMT_DEV_DISCONN_AUTH_FAILURE	0x04
 #define MGMT_DEV_DISCONN_LOCAL_HOST_SUSPEND	0x05
 
 #define MGMT_EV_DEVICE_DISCONNECTED	0x000C
Signature · 1 line
2.43.0
#2 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=965695

---Test result---

Test Summary:

CheckPatch                    PENDING   0.39 seconds
GitLint                       PENDING   0.31 seconds
BuildEll                      PASS      20.53 seconds
BluezMake                     PASS      2611.25 seconds
MakeCheck                     PASS      20.20 seconds
MakeDistcheck                 PASS      201.22 seconds
CheckValgrind                 PASS      277.99 seconds
CheckSmatch                   PASS      305.14 seconds
bluezmakeextell               PASS      130.37 seconds
IncrementalBuild              PENDING   0.30 seconds
ScanBuild                     PASS      927.61 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:

---
Regards,
Linux Bluetooth

#3 lore raw

PATCH v4 2/4 src/device: Add Disconnected signal to propagate disconnection reason

In reply to Frédéric Danis

Currently a client application is informed of the disconnection by the update of the Connected property to false.
This sends a Disconnected signal with the disconnection reason before the property is updated.

This helps client application to know the reason for the disconnection and to take appropriate action.
---
v1->v2: Propagate numerical reason instead of text one v2->v3: Replace numerical value by name and message to be more consistent
with Device.Connect error reply.

 src/adapter.c | 13 +++++++-----
 src/device.c  | 57 +++++++++++++++++++++++++++++++++++++++++++++++++--
 src/device.h  |  3 ++-
 3 files changed, 65 insertions(+), 8 deletions(-)
src/adapter.c +8 -5
index fd425e6d2..a10721489 100644
@@ -7549,7 +7549,8 @@ struct agent *adapter_get_agent(struct btd_adapter *adapter)
 
 static void adapter_remove_connection(struct btd_adapter *adapter,
 						struct btd_device *device,
-						uint8_t bdaddr_type)
+						uint8_t bdaddr_type,
+						uint8_t reason)
 {
 	bool remove_device = false;
 
@@ -7560,7 +7561,7 @@ static void adapter_remove_connection(struct btd_adapter *adapter,
 		return;
 	}
 
-	device_remove_connection(device, bdaddr_type, &remove_device);
+	device_remove_connection(device, bdaddr_type, &remove_device, reason);
 
 	device_cancel_authentication(device, TRUE);
 
@@ -7601,9 +7602,11 @@ static void adapter_stop(struct btd_adapter *adapter)
 		struct btd_device *device = adapter->connections->data;
 		uint8_t addr_type = btd_device_get_bdaddr_type(device);
 
-		adapter_remove_connection(adapter, device, BDADDR_BREDR);
+		adapter_remove_connection(adapter, device, BDADDR_BREDR,
+						MGMT_DEV_DISCONN_UNKNOWN);
 		if (addr_type != BDADDR_BREDR)
-			adapter_remove_connection(adapter, device, addr_type);
+			adapter_remove_connection(adapter, device, addr_type,
+						MGMT_DEV_DISCONN_UNKNOWN);
 	}
 
 	g_dbus_emit_property_changed(dbus_conn, adapter->path,
@@ -8551,7 +8554,7 @@ static void dev_disconnected(struct btd_adapter *adapter,
 
 	device = btd_adapter_find_device(adapter, &addr->bdaddr, addr->type);
 	if (device) {
-		adapter_remove_connection(adapter, device, addr->type);
+		adapter_remove_connection(adapter, device, addr->type, reason);
 		disconnect_notify(device, reason);
 	}
 
src/device.c +55 -2

82 lines not on this page · raw message

src/device.h +2 -1
index a35bb1386..4eebcebe9 100644
@@ -134,7 +134,8 @@ gboolean device_is_authenticating(struct btd_device *device);
 void device_add_connection(struct btd_device *dev, uint8_t bdaddr_type,
 							uint32_t flags);
 void device_remove_connection(struct btd_device *device, uint8_t bdaddr_type,
-								bool *remove);
+							bool *remove,
+							uint8_t reason);
 void device_request_disconnect(struct btd_device *device, DBusMessage *msg);
 bool device_is_disconnecting(struct btd_device *device);
 void device_set_ltk(struct btd_device *device, const uint8_t val[16],
Signature · 1 line
2.43.0
#4 lore raw

PATCH v4 3/4 doc/device: Add Disconnected signal

In reply to Frédéric Danis

---
v1->v2: Replace text reason by numerical reason
Improve documentation
v2->v3: Replace numerical reason by name and message

 doc/org.bluez.Device.rst | 41 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)
doc/org.bluez.Device.rst +41 -0
index 205f65761..39e51f79c 100644
@@ -155,6 +155,47 @@ array{array{byte}} GetServiceRecords() [experimental]
 	:org.bluez.Error.NotConnected:
 	:org.bluez.Error.DoesNotExist:
 
+Signals
+-------
+
+void Disconnected(string name, string message)
+``````````````````````````````````````````````
+
+	This signal is launched when a device is disconnected, with the reason of
+	the disconnection.
+
+	This could be used by client application, depending on internal policy, to
+	try to reconnect to the device in case of timeout or unknown disconnection,
+	or to try to connect to another device.
+
+	Possible reasons:
+
+	:org.bluez.Reason.Unknown:
+
+	:org.bluez.Reason.Timeout:
+
+		The link supervision timeout has expired for a connection or the
+		synchronization timeout has expired for a broadcast.
+
+	:org.bluez.Reason.Local:
+
+		The local device terminated the connection, terminated synchronization
+		with a broadcaster, or terminated broadcasting packets.
+
+	:org.bluez.Reason.Remote:
+
+		This disconnection can be due to:
+			- the user on the remote device either terminated the connection
+			  or stopped broadcasting packets,
+			- the remote device terminated the connection because of low
+			  resources,
+			- the remote device terminated the connection because the device
+			  is about to power off.
+
+	:org.bluez.Reason.Authentication:
+
+	:org.bluez.Reason.LocalSuspend:
+
 Properties
 ----------
 
Signature · 1 line
2.43.0
#5 lore raw

PATCH v4 4/4 client: Display disconnection reason

In reply to Frédéric Danis

The new org.bluez.Device1.Disconnected signal propagates the disconnection reason.
---
v1->v2: Display disconnect reason in numerical and text
v2->v3: Display disconnect reason name and message instead of numerical value

 client/main.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
client/main.c +18 -0
index ad35ae1fb..14d5686fb 100644
@@ -709,6 +709,24 @@ static void property_changed(GDBusProxy *proxy, const char *name,
 static void message_handler(DBusConnection *connection,
 					DBusMessage *message, void *user_data)
 {
+	if (!strcmp(dbus_message_get_member(message), "Disconnected")) {
+		const char *name;
+		const char *msg;
+
+		if (!dbus_message_get_args(message, NULL,
+					DBUS_TYPE_STRING, &name,
+					DBUS_TYPE_STRING, &msg,
+					DBUS_TYPE_INVALID))
+			goto failed;
+
+		bt_shell_printf("[SIGNAL] %s.%s %s %s\n",
+					dbus_message_get_interface(message),
+					dbus_message_get_member(message),
+					name, msg);
+		return;
+	}
+
+failed:
 	bt_shell_printf("[SIGNAL] %s.%s\n", dbus_message_get_interface(message),
 					dbus_message_get_member(message));
 }
Signature · 1 line
2.43.0
#6 lore raw
In reply to Frédéric Danis
This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Hello:

This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <[email protected]>:

Quoted 9 lines · On Fri, 23 May 2025 09:26:43 +0200 you wrote:

Currently a client application is informed of the disconnection by the update of the Connected property to false.
This sends a Disconnected signal with the disconnection reason before the property is updated.

This will help client application to know the reason for the disconnection and to take appropriate action.

[...]

Here is the summary with links:
- [BlueZ,v4,1/4] lib/mgmt: Add MGMT_DEV_DISCONN_AUTH_FAILURE define

    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=593f8b06fff2
  - [BlueZ,v4,2/4] src/device: Add Disconnected signal to propagate disconnection reason
    (no matching commit)
  - [BlueZ,v4,3/4] doc/device: Add Disconnected signal
    (no matching commit)
  - [BlueZ,v4,4/4] client: Display disconnection reason
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=1fe5a858bd97

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html