Skip to contentSkip to conversation

btrfs-progs: btrfs_setup_chunk_tree_and_device_map: Return -EIO on error.

PATCH New chandan 1 participant 1 message Sep 5, 2013 Btrfs file system

lore
Share & tools
lore

chandan

author
#0 lore raw

PATCH 1/1 btrfs-progs: btrfs_setup_chunk_tree_and_device_map: Return -EIO on error.

As a result of a successful call to btrfs_read_sys_array(), the 'ret' variable is already set to 0. Hence the function would return 0 even if the call to read_tree_block() fails.

---
 disk-io.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
disk-io.c +1 -1
index fec7700..0f69f0f 100644
@@ -966,7 +966,7 @@ int btrfs_setup_chunk_tree_and_device_map(struct btrfs_fs_info *fs_info)
 	if (!fs_info->chunk_root->node ||
 	    !extent_buffer_uptodate(fs_info->chunk_root->node)) {
 		fprintf(stderr, "Couldn't read chunk root\n");
-		return ret;
+		return -EIO;
 	}
 
 	if (!(btrfs_super_flags(sb) & BTRFS_SUPER_FLAG_METADUMP)) {
Signature · 1 line
1.8.3.1