usb: phy-am335x: clarify USB_COMMON dependency
Subsystems (2)
PATCH 1/1 usb: phy-am335x: clarify USB_COMMON dependency
The phy-am335x driver accidentally selects 'USB_COMMON', which is not correct as that symbol should indicate whether USB host or target mode is enabled, but it might not:
warning: (AM335X_PHY_USB) selects USB_COMMON which has unmet direct dependencies (USB_SUPPORT && (USB || USB_GADGET))
This changes the 'select' into 'depends on', as it should have been initially.
drivers/usb/phy/Kconfig +1 -1
@@ -63,10 +63,10 @@ config AM335X_CONTROL_USB config AM335X_PHY_USB tristate "AM335x USB PHY Driver" depends on ARM || COMPILE_TEST + depends on USB_COMMON select USB_PHY select AM335X_CONTROL_USB select NOP_USB_XCEIV - select USB_COMMON help This driver provides PHY support for that phy which part for the AM335x SoC.
Hi,
Quoted 5 lines · Arnd Bergmann
The phy-am335x driver accidentally selects '
USB_COMMON', which is not correct as that symbol should indicate whether USB host or target mode is enabled, but it might not:warning: (
AM335X_PHY_USB) selectsUSB_COMMONwhich has unmet direct dependencies (USB_SUPPORT&& (USB ||USB_GADGET))
Is it possible to have a .config which has either USB nor USB_GADGET set but AM335X_PHY_USB is set to be in the situation as in the warning above?
Quoted 3 lines
This changes the 'select' into 'depends on', as it should have been initially.
Using 'depends on' causes AM335x_PHY_USB driver unable to built-in, since USB_COMMON is an invisible option and its defualt is 'M'.
Regards,
-Bin.
Quoted 21 lines
Signed-off-by Arnd Bergmann <[email protected]>Fixes 59f042f644c5 ("usb: phy: phy-am335x: bypass first VBUS sensing for host-only mode")drivers/usb/phy/Kconfig +1
-1@@ -63,10 +63,10 @@ config AM335X_CONTROL_USB config AM335X_PHY_USB tristate "AM335x USB PHY Driver" depends on ARM || COMPILE_TEST + depends on USB_COMMON select USB_PHY select AM335X_CONTROL_USB select NOP_USB_XCEIV - select USB_COMMON help This driver provides PHY support for that phy which part for the AM335x SoC.
hi,
Quoted 12 lines · Bin Liu
Quoted 5 lines · Arnd Bergmann
The phy-am335x driver accidentally selects '
USB_COMMON', which is not correct as that symbol should indicate whether USB host or target mode is enabled, but it might not:warning: (
AM335X_PHY_USB) selectsUSB_COMMONwhich has unmet direct dependencies (USB_SUPPORT&& (USB ||USB_GADGET))Is it possible to have a .config which has either USB nor
USB_GADGETset butAM335X_PHY_USBis set to be in the situation as in the warning above?Quoted 1 line
Quoted 5 lines
Quoted 2 lines
This changes the 'select' into 'depends on', as it should have been initially.
Using 'depends on' causes
AM335x_PHY_USBdriver unable to built-in, sinceUSB_COMMONis an invisible option and its defualt is 'M'.
yeah, USB_COMMON is supposed to be selected, not depended upon.
Signature · 1 line
balbi
Quoted 16 lines · On Wednesday 03 February 2016 19:54:02 Felipe Balbi wrote:
hi,
Quoted 12 lines · Bin Liu
Quoted 5 lines · Arnd Bergmann
The phy-am335x driver accidentally selects '
USB_COMMON', which is not correct as that symbol should indicate whether USB host or target mode is enabled, but it might not:warning: (
AM335X_PHY_USB) selectsUSB_COMMONwhich has unmet direct dependencies (USB_SUPPORT&& (USB ||USB_GADGET))Is it possible to have a .config which has either USB nor
USB_GADGETset butAM335X_PHY_USBis set to be in the situation as in the warning above?Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
This changes the 'select' into 'depends on', as it should have been initially.
Using 'depends on' causes
AM335x_PHY_USBdriver unable to built-in, sinceUSB_COMMONis an invisible option and its defualt is 'M'.yeah,
USB_COMMONis supposed to be selected, not depended upon.
That means we should do something like the patch below?
Fine with me too, but maybe you can write the changelog for that, as I don't know the background behind the logic.
Arnd
drivers/phy/Kconfig +2 -1
@@ -249,7 +249,8 @@ config PHY_SUN9I_USB tristate "Allwinner sun9i SoC USB PHY driver" depends on ARCH_SUNXI && HAS_IOMEM && OF depends on RESET_CONTROLLER - depends on USB_COMMON + depends on USB_SUPPORT + select USB_COMMON select GENERIC_PHY help Enable this to support the transceiver that is part of Allwinner
drivers/usb/Kconfig +1 -2
@@ -31,8 +31,6 @@ if USB_SUPPORT config USB_COMMON tristate - default y - depends on USB || USB_GADGET config USB_ARCH_HAS_HCD def_bool y
@@ -41,6 +39,7 @@ config USB_ARCH_HAS_HCD config USB tristate "Support for Host-side USB" depends on USB_ARCH_HAS_HCD + select USB_COMMON select NLS # for UTF-8 strings ---help--- Universal Serial Bus (USB) is a specification for a serial bus
drivers/usb/gadget/Kconfig +1 -0
@@ -15,6 +15,7 @@ menuconfig USB_GADGET tristate "USB Gadget Support" + select USB_COMMON select NLS help USB is a master/slave protocol, organized with one master
Hi,
Quoted 69 lines · Arnd Bergmann
Quoted 12 lines
Quoted 12 lines · Arnd Bergmann
Quoted 5 lines
The phy-am335x driver accidentally selects '
USB_COMMON', which is not correct as that symbol should indicate whether USB host or target mode is enabled, but it might not:warning: (
AM335X_PHY_USB) selectsUSB_COMMONwhich has unmet direct dependencies (USB_SUPPORT&& (USB ||USB_GADGET))Is it possible to have a .config which has either USB nor
USB_GADGETset butAM335X_PHY_USBis set to be in the situation as in the warning above?Quoted 1 line
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
This changes the 'select' into 'depends on', as it should have been initially.
Using 'depends on' causes
AM335x_PHY_USBdriver unable to built-in, sinceUSB_COMMONis an invisible option and its defualt is 'M'.yeah,
USB_COMMONis supposed to be selected, not depended upon.That means we should do something like the patch below?
Fine with me too, but maybe you can write the changelog for that, as I don't know the background behind the logic.
Arnd
drivers/phy/Kconfig +2
-1@@ -249,7 +249,8 @@ config PHY_SUN9I_USB tristate "Allwinner sun9i SoC USB PHY driver" depends on ARCH_SUNXI && HAS_IOMEM && OF depends on RESET_CONTROLLER - depends on USB_COMMON + depends on USB_SUPPORT + select USB_COMMON select GENERIC_PHY help Enable this to support the transceiver that is part of Allwinnerdrivers/usb/Kconfig +1
-2@@ -31,8 +31,6 @@ if USB_SUPPORT config USB_COMMON tristate - default y - depends on USB || USB_GADGET config USB_ARCH_HAS_HCD def_bool y@@ -41,6 +39,7 @@ config USB_ARCH_HAS_HCD config USB tristate "Support for Host-side USB" depends on USB_ARCH_HAS_HCD + select USB_COMMON select NLS # for UTF-8 strings ---help--- Universal Serial Bus (USB) is a specification for a serial busdrivers/usb/gadget/Kconfig +0
-0
drivers/usb/gadget/Kconfig line 21
Quoted 7 lines
drivers/usb/gadget/Kconfig +1
-0@@ -15,6 +15,7 @@ menuconfig USB_GADGET tristate "USB Gadget Support" + select USB_COMMON select NLS help USB is a master/slave protocol, organized with one master
looks great to me. Care to send it in proper patch form ?
Signature · 1 line
balbi