Skip to contentSkip to conversation

selftests: drv-net: add configs for the TSO test

PATCH Applied Jakub Kicinski 3 participants 4 messages Jun 4, 2025 – Jun 5, 2025

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH v2 1/1 selftests: drv-net: add configs for the TSO test

Add missing config options for the tso.py test, specifically to make sure the kernel is built with vxlan and gre tunnels.

I noticed this while adding a TSO-capable device QEMU to the CI. Previously we only run virtio tests and it doesn't report LSO stats on the QEMU we have.

Fixes 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")

---
v2:
- drop NET_IP_TUNNEL
v1: https://lore.kernel.org/[email protected]

---
 tools/testing/selftests/drivers/net/hw/config | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 tools/testing/selftests/drivers/net/hw/config
tools/testing/selftests/drivers/net/hw/config new file +5 -0
new file mode 100644
index 000000000000..88ae719e6f8f
@@ -0,0 +1,5 @@
+CONFIG_IPV6=y
+CONFIG_IPV6_GRE=y
+CONFIG_NET_IPGRE=y
+CONFIG_NET_IPGRE_DEMUX=y
+CONFIG_VXLAN=y
Signature · 1 line
2.49.0
Reviewed-by on v2 1/1
#1 lore raw
Quoted 9 lines · Jakub Kicinski

Add missing config options for the tso.py test, specifically to make sure the kernel is built with vxlan and gre tunnels.

I noticed this while adding a TSO-capable device QEMU to the CI. Previously we only run virtio tests and it doesn't report LSO stats on the QEMU we have.

Fixes 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")

I wonder if we'll slowly recreate tools/testing/selftests/net/config. An ugly hack, but maybe let the Makefile just copy that config here? Or append it.

author maintainer
#2 lore raw
Quoted 8 lines · On Wed, 04 Jun 2025 09:47:48 -0400 Willem de Bruijn wrote:
Quoted 7 lines · Jakub Kicinski

Add missing config options for the tso.py test, specifically to make sure the kernel is built with vxlan and gre tunnels.

I noticed this while adding a TSO-capable device QEMU to the CI. Previously we only run virtio tests and it doesn't report LSO stats on the QEMU we have.

Quoted 8 lines
Quoted 2 lines
Fixes 0d0f4174f6c8 ("selftests: drv-net: add a simple TSO test")

I wonder if we'll slowly recreate tools/testing/selftests/net/config. An ugly hack, but maybe let the Makefile just copy that config here? Or append it.

Yes, even drivers/net vs drivers/net/hw is a bit annoying. Not sure how to cleanly align with selftest infra here :( Our CI right now only uses configs from the TARGETS we're intending to run. While it makes sense "to a human" to include net, is it clean to auto-include $target if drivers/$target is included? Maybe...

To some extent I think the issue was that we haven't actually had any device on which NIPA could run this test. Otherwise we'd have caught the problem before merging.

#3 lore raw
In reply to Jakub Kicinski
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Tue, 3 Jun 2025 17:16:52 -0700 you wrote:

Add missing config options for the tso.py test, specifically to make sure the kernel is built with vxlan and gre tunnels.

I noticed this while adding a TSO-capable device QEMU to the CI. Previously we only run virtio tests and it doesn't report LSO stats on the QEMU we have.

[...]

Here is the summary with links:
- [net,v2] selftests: drv-net: add configs for the TSO test

    https://git.kernel.org/netdev/net/c/7eb6b63aa3c3

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html