Skip to contentSkip to conversation

net: remove unused sock_enable_timestamps

PATCH Applied Willem de Bruijn 3 participants 3 messages Jun 9, 2025 – Jun 10, 2025

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: remove unused sock_enable_timestamps

From: Willem de Bruijn <[email protected]>

This function was introduced in commit 783da70e8396 ("net: add sock_enable_timestamps"), with one caller in rxrpc.

That only caller was removed in commit 7903d4438b3f ("rxrpc: Don't use received skbuff timestamps").

---
 include/net/sock.h | 1 -
 net/core/sock.c    | 8 --------
 2 files changed, 9 deletions(-)
include/net/sock.h +0 -1
index 92e7c1aae3cc..85e17da5c9db 100644
@@ -2982,7 +2982,6 @@ void sock_set_timestamp(struct sock *sk, int optname, bool valbool);
 int sock_set_timestamping(struct sock *sk, int optname,
 			  struct so_timestamping timestamping);
 
-void sock_enable_timestamps(struct sock *sk);
 #if defined(CONFIG_CGROUP_BPF)
 void bpf_skops_tx_timestamping(struct sock *sk, struct sk_buff *skb, int op);
 #else
net/core/sock.c +0 -8
index 3b409bc8ef6d..502042a0d3b5 100644
@@ -837,14 +837,6 @@ static void __sock_set_timestamps(struct sock *sk, bool val, bool new, bool ns)
 	}
 }
 
-void sock_enable_timestamps(struct sock *sk)
-{
-	lock_sock(sk);
-	__sock_set_timestamps(sk, true, false, true);
-	release_sock(sk);
-}
-EXPORT_SYMBOL(sock_enable_timestamps);
-
 void sock_set_timestamp(struct sock *sk, int optname, bool valbool)
 {
 	switch (optname) {
Signature · 1 line
2.50.0.rc0.604.gd4ff7b7c86-goog
#2 lore raw
In reply to Willem de Bruijn
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Mon, 9 Jun 2025 11:32:35 -0400 you wrote:

From: Willem de Bruijn <[email protected]>

This function was introduced in commit 783da70e8396 ("net: add sock_enable_timestamps"), with one caller in rxrpc.

That only caller was removed in commit 7903d4438b3f ("rxrpc: Don't use received skbuff timestamps").

[...]

Here is the summary with links:
- [net-next] net: remove unused sock_enable_timestamps

    https://git.kernel.org/netdev/net-next/c/561939ed4493

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html