netconsole: fix appending sysdata when sysdata_fields == SYSDATA_RELEASE
Subsystems (3)
Gustavo Luiz Duarte
reviewerPATCH 1/1 netconsole: fix appending sysdata when sysdata_fields == SYSDATA_RELEASE
Before appending sysdata, prepare_extradata() checks if any feature is enabled in sysdata_fields (and exits early if none is enabled).
When SYSDATA_RELEASE was introduced, we missed adding it to the list of features being checked against sysdata_fields in prepare_extradata(). The result was that, if only SYSDATA_RELEASE is enabled in sysdata_fields, we incorreclty exit early and fail to append the release.
Instead of checking specific bits in sysdata_fields, check if sysdata_fields has ALL bit zeroed and exit early if true. This fixes case when only SYSDATA_RELEASE enabled and makes the code more general / less error prone in future feature implementation.
--- drivers/net/netconsole.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/netconsole.c +1 -2
@@ -1252,7 +1252,6 @@ static int sysdata_append_release(struct netconsole_target *nt, int offset)*/ static int prepare_extradata (struct netconsole_target *nt) { -u32 fields =SYSDATA_CPU_NR |SYSDATA_TASKNAME ;int extradata_len;/* userdata was appended when configfs write helper was called
@@ -1260,7 +1259,7 @@ static int prepare_extradata(struct netconsole_target *nt)*/ extradata_len = nt->userdata_length; -if (!(nt->sysdata_fields & fields)) +if (!nt->sysdata_fields) goto out;if (nt->sysdata_fields &SYSDATA_CPU_NR )
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250609-netconsole-fix-5465e2fd8f83
Best regards,
Signature · 1 line
Gustavo Luiz Duarte <[email protected]>
Quoted 9 lines · Gustavo Luiz Duarte
Before appending sysdata,
prepare_extradata()checks if any feature is enabled insysdata_fields(and exits early if none is enabled).When
SYSDATA_RELEASEwas introduced, we missed adding it to the list of features being checked againstsysdata_fieldsinprepare_extradata(). The result was that, if onlySYSDATA_RELEASEis enabled insysdata_fields, we incorreclty exit early and fail to append the release.
Quoted 6 lines
Instead of checking specific bits in
sysdata_fields, check ifsysdata_fieldshas ALL bit zeroed and exit early if true. This fixes case when onlySYSDATA_RELEASEenabled and makes the code more general / less error prone in future feature implementation.Signed-off-by Gustavo Luiz Duarte <[email protected]>
Thanks for the fix,
--breno
This patch was applied to netdev/net.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
Quoted 10 lines · On Mon, 09 Jun 2025 11:24:20 -0700 you wrote:
Before appending sysdata,
prepare_extradata()checks if any feature is enabled insysdata_fields(and exits early if none is enabled).When
SYSDATA_RELEASEwas introduced, we missed adding it to the list of features being checked againstsysdata_fieldsinprepare_extradata(). The result was that, if onlySYSDATA_RELEASEis enabled insysdata_fields, we incorreclty exit early and fail to append the release.[...]
Here is the summary with links:
- [net] netconsole: fix appending sysdata when sysdata_fields == SYSDATA_RELEASE
https://git.kernel.org/netdev/net/c/c85bf1975108
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html