net: phy: assign default match function for non-PHY MDIO devices
Subsystems (3)
Heiner Kallweit
maintainerPATCH 1/1 net: phy: assign default match function for non-PHY MDIO devices
Make mdio_device_bus_match() the default match function for non-PHY MDIO devices. Benefit is that we don't have to export this function any longer. As long as mdiodev->modalias isn't set, there's no change in behavior. mdiobus_create_device() is the only place where mdiodev->modalias gets set, but this function sets mdio_device_bus_match() as match function anyway.
--- drivers/net/phy/mdio_bus_provider.c | 1 - drivers/net/phy/mdio_device.c | 5 +++-- include/linux/mdio.h | 1 - 3 files changed, 3 insertions(+), 4 deletions(-)
drivers/net/phy/mdio_bus_provider.c +0 -1
@@ -152,7 +152,6 @@ static int mdiobus_create_device(struct mii_bus *bus,strscpy (mdiodev->modalias, bi->modalias,sizeof (mdiodev->modalias)); - mdiodev->bus_match = mdio_device_bus_match; mdiodev->dev.platform_data = (void *)bi->platform_data; ret =mdio_device_register (mdiodev);
drivers/net/phy/mdio_device.c +3 -2
@@ -35,7 +35,8 @@ static void mdio_device_release(struct device *dev)kfree (to_mdio_device (dev)); } -int mdio_device_bus_match (struct device *dev,const struct device_driver *drv) +static int mdio_device_bus_match (struct device *dev, +const struct device_driver *drv) {struct mdio_device *mdiodev =to_mdio_device (dev);const struct mdio_driver *mdiodrv =to_mdio_driver (drv);
@@ -45,7 +46,6 @@ int mdio_device_bus_match(struct device *dev, const struct device_driver *drv)return strcmp (mdiodev->modalias, drv->name) ==0 ; } -EXPORT_SYMBOL_GPL (mdio_device_bus_match);struct mdio_device *mdio_device_create (struct mii_bus *bus,int addr) {
@@ -59,6 +59,7 @@ struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr) mdiodev->dev.release = mdio_device_release; mdiodev->dev.parent = &bus->dev; mdiodev->dev.bus = &mdio_bus_type; + mdiodev->bus_match = mdio_device_bus_match; mdiodev->device_free = mdio_device_free; mdiodev->device_remove = mdio_device_remove; mdiodev->bus = bus;
include/linux/mdio.h +0 -1
@@ -98,7 +98,6 @@ void mdio_device_remove(struct mdio_device *mdiodev);void mdio_device_reset (struct mdio_device *mdiodev,int value);int mdio_driver_register (struct mdio_driver *drv);void mdio_driver_unregister (struct mdio_driver *drv); -int mdio_device_bus_match (struct device *dev,const struct device_driver *drv);static inline void mdio_device_get (struct mdio_device *mdiodev) {
Signature · 1 line
2.49.0
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Tue, 10 Jun 2025 08:03:43 +0200 you wrote:
Make
mdio_device_bus_match()the default match function for non-PHY MDIO devices. Benefit is that we don't have to export this function any longer. As long asmdiodev->modaliasisn't set, there's no change in behavior.mdiobus_create_device()is the only place wheremdiodev->modaliasgets set, but this function setsmdio_device_bus_match()as match function anyway.[...]
Here is the summary with links:
- [RESUBMIT,net-next] net: phy: assign default match function for non-PHY MDIO devices
https://git.kernel.org/netdev/net-next/c/b1b36680107e
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html