net: stmmac: improve .set_clk_tx_rate() method error message
Subsystems (4)
PATCH 1/1 net: stmmac: improve .set_clk_tx_rate() method error message
Improve the .set_clk_tx_rate() method error message to include the PHY interface mode along with the speed, which will be helpful to the RK implementations.
--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +2 -2
@@ -1062,8 +1062,8 @@ static void stmmac_mac_link_up(struct phylink_config *config, interface, speed);if (ret <0 )netdev_err (priv->dev, -"failed to configure transmit clock for %dMbps: %pe\n" , - speed,ERR_PTR (ret)); +"failed to configure %s transmit clock for %dMbps: %pe\n" , +phy_modes (interface), speed,ERR_PTR (ret)); }stmmac_mac_set (priv, priv->ioaddr, true);
Signature · 1 line
2.30.2
Quoted 5 lines · Russell King (Oracle)
Improve the .set_clk_tx_rate() method error message to include the PHY interface mode along with the speed, which will be helpful to the RK implementations.
Signed-off-by Russell King (Oracle) <[email protected]>
Andrew
Quoted 14 lines · Russell King (Oracle)
Improve the .set_clk_tx_rate() method error message to include the PHY interface mode along with the speed, which will be helpful to the RK implementations.
Signed-off-by Russell King (Oracle) <[email protected]>--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +0
-0
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c static void stmmac_mac_link_up(struct phylink_config *config, · line 1069
Quoted 10 lines
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +2
-2@@ -1062,8 +1062,8 @@ static void stmmac_mac_link_up(struct phylink_config *config, interface, speed);if (ret <0 )netdev_err (priv->dev, -"failed to configure transmit clock for %dMbps: %pe\n" , - speed,ERR_PTR (ret)); +"failed to configure %s transmit clock for %dMbps: %pe\n" , +phy_modes (interface), speed,ERR_PTR (ret)); }stmmac_mac_set (priv, priv->ioaddr, true);
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Hello:
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:
Quoted 8 lines · On Thu, 12 Jun 2025 16:21:17 +0100 you wrote:
Improve the .set_clk_tx_rate() method error message to include the PHY interface mode along with the speed, which will be helpful to the RK implementations.
Signed-off-by Russell King (Oracle) <[email protected]>--- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Here is the summary with links:
- [net-next] net: stmmac: improve .set_clk_tx_rate() method error message
https://git.kernel.org/netdev/net-next/c/bd1d76a6f18f
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html