xmalloc: drop pool list
PATCH 1/1 xmalloc: drop pool list
From its introduction it has been used solely to add and remove pools. No list traversal or alike did ever occur. Drop all of this as being dead code.
Signed-off-by Jan Beulich <[email protected]>
xen/common/xmalloc_tlsf.c +0 -13
@@ -66,9 +66,6 @@#define PREV_FREE (0x2)#define PREV_USED (0x0) -static DEFINE_SPINLOCK (pool_list_lock); -static LIST_HEAD (pool_list_head); -struct free_ptr {struct bhdr *prev;struct bhdr *next;
@@ -113,8 +110,6 @@ struct xmem_pool {xmem_pool_get_memory *get_mem;xmem_pool_put_memory *put_mem; -struct list_head list; -char name[MAX_POOL_NAME_LEN ]; };
@@ -340,10 +335,6 @@ struct xmem_pool *xmem_pool_create(spin_lock_init (&pool->lock); -spin_lock (&pool_list_lock); -list_add_tail (&pool->list, &pool_list_head); -spin_unlock (&pool_list_lock); -return pool; }
@@ -373,10 +364,6 @@ void xmem_pool_destroy(struct xmem_pool"%lu bytes still in use.\n" , pool->name, pool, xmem_pool_get_used_size(pool)); -spin_lock (&pool_list_lock); -list_del_init (&pool->list); -spin_unlock (&pool_list_lock); - pool_bytes =ROUNDUP_SIZE (sizeof (*pool)); pool_order =get_order_from_bytes (pool_bytes);free_xenheap_pages (pool,pool_order);
Quoted 40 lines · Jan Beulich
From its introduction it has been used solely to add and remove pools.
No list traversal or alike did ever occur. Drop all of this as being dead code.Signed-off-by Jan Beulich <[email protected]>xen/common/xmalloc_tlsf.c +0
-9@@ -66,9 +66,6 @@#define PREV_FREE (0x2)#define PREV_USED (0x0) -static DEFINE_SPINLOCK (pool_list_lock); -static LIST_HEAD (pool_list_head); -struct free_ptr {struct bhdr *prev;struct bhdr *next;@@ -113,8 +110,6 @@ struct xmem_pool {xmem_pool_get_memory *get_mem;xmem_pool_put_memory *put_mem; -struct list_head list; -char name[MAX_POOL_NAME_LEN ]; };@@ -340,10 +335,6 @@ struct xmem_pool *xmem_pool_create(spin_lock_init (&pool->lock); -spin_lock (&pool_list_lock); -list_add_tail (&pool->list, &pool_list_head); -spin_unlock (&pool_list_lock); -return pool; }
xen/common/xmalloc_tlsf.c void xmem_pool_destroy(struct xmem_pool · line 369
Quoted 10 lines
xen/common/xmalloc_tlsf.c +0
-4@@ -373,10 +364,6 @@ void xmem_pool_destroy(struct xmem_pool"%lu bytes still in use.\n" , pool->name, pool, xmem_pool_get_used_size(pool)); -spin_lock (&pool_list_lock); -list_del_init (&pool->list); -spin_unlock (&pool_list_lock); - pool_bytes =ROUNDUP_SIZE (sizeof (*pool)); pool_order =get_order_from_bytes (pool_bytes);free_xenheap_pages (pool,pool_order);
LGTM:
Reviewed-by Oleksii Kurochko <[email protected]>
~ Oleksii
Quoted 5 lines · Jan Beulich
From its introduction it has been used solely to add and remove pools. No list traversal or alike did ever occur. Drop all of this as being dead code.
Signed-off-by Jan Beulich <[email protected]>
Reviewed-by Andrew Cooper <[email protected]>