Skip to contentSkip to conversation

selftests/tc-testing: sfq: check perturb timer values

PATCH Applied Eric Dumazet 4 participants 4 messages Jun 13, 2025 – Jun 16, 2025

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests/tc-testing: sfq: check perturb timer values

Add one test to check that the kernel rejects a negative perturb timer.

Add a second test checking that the kernel rejects a too big perturb timer.

All test results:

1..2
ok 1 cdc1 - Check that a negative perturb timer is rejected ok 2 a9f0 - Check that a too big perturb timer is rejected

---
 .../tc-testing/tc-tests/qdiscs/sfq.json       | 36 +++++++++++++++++++
 1 file changed, 36 insertions(+)
tools/testing/selftests/tc-testing/tc-tests/qdiscs/sfq.json +36 -0
index 28c6ce6da7dbb829765517f989d5441aab98f901..531a2f6e49001e9390eabaef1b545d6836cecb58 100644
@@ -264,5 +264,41 @@
         "matchPattern": "sfq",
         "matchCount": "0",
         "teardown": []
+    },
+    {
+        "id": "cdc1",
+        "name": "Check that a negative perturb timer is rejected",
+        "category": [
+            "qdisc",
+            "sfq"
+        ],
+        "plugins": {
+            "requires": "nsPlugin"
+        },
+        "setup": [],
+        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root sfq perturb -10",
+        "expExitCode": "2",
+        "verifyCmd": "$TC qdisc show dev $DUMMY",
+        "matchPattern": "sfq",
+        "matchCount": "0",
+        "teardown": []
+    },
+    {
+        "id": "a9f0",
+        "name": "Check that a too big perturb timer is rejected",
+        "category": [
+            "qdisc",
+            "sfq"
+        ],
+        "plugins": {
+            "requires": "nsPlugin"
+        },
+        "setup": [],
+        "cmdUnderTest": "$TC qdisc add dev $DUMMY handle 1: root sfq perturb 1000000000",
+        "expExitCode": "2",
+        "verifyCmd": "$TC qdisc show dev $DUMMY",
+        "matchPattern": "sfq",
+        "matchCount": "0",
+        "teardown": []
     }
 ]
Signature · 1 line
2.50.0.rc1.591.g9c95f17f64-goog
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Eric Dumazet

Add one test to check that the kernel rejects a negative perturb timer.

Add a second test checking that the kernel rejects a too big perturb timer.

Quoted 7 lines

All test results:

1..2
ok 1 cdc1 - Check that a negative perturb timer is rejected ok 2 a9f0 - Check that a too big perturb timer is rejected

Reviewed-by on v1 1/1
#2 lore raw
In reply to Eric Dumazet
Quoted 6 lines · Eric Dumazet

Add one test to check that the kernel rejects a negative perturb timer.

Add a second test checking that the kernel rejects a too big perturb timer.

Quoted 7 lines

All test results:

1..2
ok 1 cdc1 - Check that a negative perturb timer is rejected ok 2 a9f0 - Check that a too big perturb timer is rejected

Thanks!

#3 lore raw
In reply to Eric Dumazet
This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 8 lines · On Fri, 13 Jun 2025 06:41:36 +0000 you wrote:

Add one test to check that the kernel rejects a negative perturb timer.

Add a second test checking that the kernel rejects a too big perturb timer.

All test results:

[...]

Here is the summary with links:
- [net-next] selftests/tc-testing: sfq: check perturb timer values

    https://git.kernel.org/netdev/net-next/c/de74998c3008

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html